Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

551-add-new-logo #601

Merged
b24johka merged 4 commits from 551-add-new-logo into team_1_week_3 2026-04-28 07:50:27 +00:00
Conversation 3 Commits 4 Files changed 4 +1775 -1
b24erika commented 2026-04-28 07:21:04 +00:00
Collaborator
Copy link

New logo replace the text in navbar, now linked so when pressed you are returned to home-page. I did not remove the other logo from the navbar that has the same functionality since we want customer feedback. SVG is also added to the asset folder, the problem is that the whole image is displayed and it seems that I can not remove the background.

New logo replace the text in navbar, now linked so when pressed you are returned to home-page. I did not remove the other logo from the navbar that has the same functionality since we want customer feedback. SVG is also added to the asset folder, the problem is that the whole image is displayed and it seems that I can not remove the background.
2 new logos added to assets
b24erika commented 2026-04-28 07:22:51 +00:00
Author
Collaborator
Copy link

Visual representation of how it looks like with and without the existing logo.

Visual representation of how it looks like with and without the existing logo.
bild.png
132 KiB
bild.png
128 KiB
bild.png bild.png
b24johka commented 2026-04-28 07:40:46 +00:00
Collaborator
Copy link

Looks good. tried it in responsive mode and i feel like the margin is somewhat too small to the cogwheel. But since we are replacing the cogwheel its fine. Good job, Looks great!

Looks good. tried it in responsive mode and i feel like the margin is somewhat too small to the cogwheel. But since we are replacing the cogwheel its fine. Good job, Looks great!
image.png
53 KiB
image.png
b24johka commented 2026-04-28 07:50:18 +00:00
Collaborator
Copy link

Review on #601

Whats done

Tested using Firefox with responsive mode

Inspected following files

  • Navbar.js
    • Looks good, clear semantics and clean.
  • Navbar.module.css
    • Looks good, clear semantics and clean.

What needs to be done

Nothing it's all good.

Conclusion

No specific changes needed. Can be merged.

# Review on #601 ## Whats done ### Tested using Firefox with responsive mode ### Inspected following files + Navbar.js + Looks good, clear semantics and clean. + Navbar.module.css + Looks good, clear semantics and clean. ## What needs to be done Nothing it's all good. ## Conclusion No specific changes needed. Can be merged.
b24johka merged commit 7fa50576d4 into team_1_week_3 2026-04-28 07:50:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b24johka
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b24erika
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!601
No description provided.