Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#459-TempratureGraph-Fix-and-APIhook #627

Merged
b24johka merged 4 commits from #459-TempratureGraph-Fix-and-APIhook into team_1_week_3 2026-04-29 07:43:49 +00:00
Conversation 4 Commits 4 Files changed 3 +122 -75
a24hirsa commented 2026-04-28 12:37:18 +00:00
Collaborator
Copy link
No description provided.
b24hugst commented 2026-04-28 14:12:11 +00:00
Collaborator
Copy link

Review on #459

Whats done

Looked over code

Tested on [Windows 11] using [Chrome]

  • API is correctly used
  • TemperatureGraph show output
  • App starts
    • Text in view always stays black which makes it hard to see when using Dark Mode
    • image

Inspected following files

  • WeatherGraph.js
    • Indentation/code styling follows prettier
    • Naming convention
      • Follows standard
    • Comments
      • Not all comments start with capital and one of them is a bit poorly worded
      • image
    • General code quality
      • Good!

What needs to be done

Update so text in view is white instead of black
Update the comments just a bit

Conclusion

  • Can be merged after updates are made.
# Review on #459 ## Whats done Looked over code ### Tested on [Windows 11] using [Chrome] + API is correctly used + TemperatureGraph show output + App starts + Text in view always stays black which makes it hard to see when using Dark Mode + ![image](/attachments/66c54344-1f34-45ff-93c2-bf465d23b757) ### Inspected following files + WeatherGraph.js + Indentation/code styling follows prettier + Naming convention + Follows standard + Comments + Not all comments start with capital and one of them is a bit poorly worded + ![image](/attachments/7b9b75da-c196-4551-9504-e45eeda027c1) + General code quality + Good! ## What needs to be done Update so text in view is white instead of black Update the comments just a bit ## Conclusion + Can be merged after updates are made.
image.png
2 KiB
image.png
16 KiB
a24hirsa commented 2026-04-29 07:39:25 +00:00
Author
Collaborator
Copy link

Fixade till font färgen och kommentarerna

Fixade till font färgen och kommentarerna
a24hirsa commented 2026-04-29 07:40:41 +00:00
Author
Collaborator
Copy link
No description provided.
Screenshot_20260429_093954.png
30 KiB
Screenshot_20260429_093954.png
b24johka commented 2026-04-29 07:43:36 +00:00
Collaborator
Copy link

The review is sufficient and this will be merged right away.

The review is sufficient and this will be merged right away.
b24johka merged commit 0798bd9bc1 into team_1_week_3 2026-04-29 07:43:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b24hugst
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!627
No description provided.