#628-Fix-team-2-tmp-service-V4 #656

Merged

c24elipe merged 2 commits from #628-Fix-team-2-tmp-service-V4 into week_4_temp_branch

2026-04-30 10:52:40 +00:00

a22erigr commented

2026-04-29 14:15:45 +00:00

Collaborator

changed sql queries
change business logic for year and year month
Tested on my computer using bruno. Works

+ changed sql queries + change business logic for year and year month + Tested on my computer using bruno. Works

a22erigr added 2 commits

2026-04-29 14:15:46 +00:00

fix /temperature/latest/ 67c3398e90

TempService is not fixex 085e052594

+ changed sql queries
+ change business logic for year and year month
+ Tested on my computer using bruno. Works

a24vinla commented

2026-04-29 14:19:25 +00:00

Collaborator

![LGTM](/attachments/85b2f0ad-181a-495b-89c2-207218c2755a)

a22erigr added 1 commit

2026-04-30 07:27:29 +00:00

Cleanup 9da8ef9ded

+ Endpoints now error message
+ Moved interface for service to separate file

a22erigr added the

needs review

Team 2

labels

2026-04-30 07:29:53 +00:00

a22erigr was assigned by c24elipe

2026-04-30 07:31:41 +00:00

a24timsv requested review from c24danli

2026-04-30 09:35:50 +00:00

c24danli commented

2026-04-30 10:17:23 +00:00

Collaborator

Review on #628

Whats done

Tested on Windows 11 using chrome

App starts
- TempView works now (too many decimals real insted of duble middleware issue),
- BookingView dont work(worked before) need to change how we call the api in frontend
- " HTTP 404 from TemperatureView", old fix was on the querry now its not implimented,(should probebly be implimented in frontend if we can find a fix)
- Data can be querried from db correctly but we have many end points to add/fix will need comperation from someone who impliments the view and backend, we need to know what data is needed from querries

Inspected following files

service/tempService/tempService/Services/TempService.cs
- Indentation/code styling
  - ok
- Naming convention
  - ok
- Comments
  - exist out comented code
- General code quality
  - Good, now there exist more seperation between resposibilities witch was what the issue set out to do.
service/tempService/tempService/Services/ITempService.cs
- Indentation/code styling
  - ok
- Naming convention
  - ok
- Comments
  - ok
- General code quality
  - Good, now there exist more seperation between resposibilities witch was what the issue set out to do.
scripts/UnixRebuild.sh
- cant test unix build script.
service/tempService/tempService/Services/ITempService.cs
- Indentation/code styling
  - ok
- Naming convention
  - ok
- Comments
  - ok
- General code quality
  - Good, now there exist more seperation between resposibilities witch was what the issue set out to do.

What needs to be done

[Here you should write the things that needs to be fixed.]

Both in Views and in endpoints/querries
- we need to create issues were those who makes the views document what endpoint they need and what data needs to be querried.
remove unused code in service/tempService/tempService/Services/ITempService.cs

Conclusion

ok to merge but more issues needs to be created to make existing views comply to new backend structure

# Review on #628 ## Whats done ### Tested on Windows 11 using chrome + App starts + TempView works now (too many decimals real insted of duble middleware issue), + BookingView dont work(worked before) need to change how we call the api in frontend + " HTTP 404 from TemperatureView", old fix was on the querry now its not implimented,(should probebly be implimented in frontend if we can find a fix) + Data can be querried from db correctly but we have many end points to add/fix will need comperation from someone who impliments the view and backend, we need to know what data is needed from querries ### Inspected following files + service/tempService/tempService/Services/TempService.cs + Indentation/code styling + ok + Naming convention + ok + Comments + exist out comented code + General code quality + Good, now there exist more seperation between resposibilities witch was what the issue set out to do. + service/tempService/tempService/Services/ITempService.cs + Indentation/code styling + ok + Naming convention + ok + Comments + ok + General code quality + Good, now there exist more seperation between resposibilities witch was what the issue set out to do. + scripts/UnixRebuild.sh + cant test unix build script. + service/tempService/tempService/Services/ITempService.cs + Indentation/code styling + ok + Naming convention + ok + Comments + ok + General code quality + Good, now there exist more seperation between resposibilities witch was what the issue set out to do. ## What needs to be done [Here you should write the things that needs to be fixed.] + Both in Views and in endpoints/querries + we need to create issues were those who makes the views document what endpoint they need and what data needs to be querried. + remove unused code in service/tempService/tempService/Services/ITempService.cs ## Conclusion + ok to merge but more issues needs to be created to make existing views comply to new backend structure