Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

Update HamburgerMenu.module.css #676

Merged
b24johka merged 2 commits from #672-centering-spans into team_1_week_4 2026-04-30 13:32:14 +00:00
Conversation 3 Commits 2 Files changed 2 +8 -4
a24julot commented 2026-04-30 11:19:49 +00:00
Collaborator
Copy link

Spans for HamburgerMenu is centered.

Spans for HamburgerMenu is centered.
spans.png
10 KiB
spans.png
j21marbr commented 2026-04-30 12:54:39 +00:00
Collaborator
Copy link

Review on #676

Whats done

Tested on Iphone (safari)

  • App starts
    • Hanburger menu opens correctly
    • Menu closes when scrolling on mobile
    • Menu works with touch (pointerdown)

Inspected following files

  • HamburgerMenu.js

    • Indentation/code styling
      • Follows standard
    • Naming convention
      • Follows standard
    • Comments
      • Looks good
    • General code quality
      • Event handling works correctly (pointerdown)

  • HamburgerMenu.module.css

    • Indentation/code styling
      • Follows standard
    • Naming convention
      • Follows standard
    • Comments
      • Looks good
    • General code quality
      • No issue found
      • Hamburger menu spans are correctly centered

What needs to be done

  • No issue found.

Conclusion

  • Works as intended and the code is ready to be merged.
# Review on #676 ## Whats done ### Tested on Iphone (safari) + App starts + Hanburger menu opens correctly + Menu closes when scrolling on mobile + Menu works with touch (pointerdown) ### Inspected following files + HamburgerMenu.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + Event handling works correctly (pointerdown) + HamburgerMenu.module.css + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + No issue found + Hamburger menu spans are correctly centered ## What needs to be done + No issue found. ## Conclusion + Works as intended and the code is ready to be merged.
j21marbr commented 2026-04-30 12:55:47 +00:00
Collaborator
Copy link
No description provided.
vid.MP4
4.2 MiB
b24johka commented 2026-04-30 13:32:08 +00:00
Collaborator
Copy link

Great review! This will be merged right away.

Great review! This will be merged right away.
b24johka merged commit bf726d9b2a into team_1_week_4 2026-04-30 13:32:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
j21marbr
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
a24julot
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!676
No description provided.