Andras/BoundlessFlowCampus2K

Fork 0

649-Footer-not-moving-whit-grid #685

Closed

a24hamrh wants to merge 0 commits from 649-Footer-not-moving-with-grid into team_1_week_4

a24hamrh commented

2026-04-30 14:12:01 +00:00

Collaborator

Now the footer is underneath the grid and follows it when it expands.

Whats done:

Set the totalRowHeight to rowHeight for a more dynamic gridsize.
Changed the minRowsToFillScreen calculation to round down instead of up. This is to ensure the grid is not overlapping the footer.
Moved gridSizes above totalRowHeight so we can use rowHeight whit it.

## Now the footer is underneath the grid and follows it when it expands. ### Whats done: + Set the totalRowHeight to rowHeight for a more dynamic gridsize. + Changed the minRowsToFillScreen calculation to round down instead of up. This is to ensure the grid is not overlapping the footer. + Moved gridSizes above totalRowHeight so we can use rowHeight whit it.

a24hamrh added the

needs review

label

2026-04-30 14:12:01 +00:00

a24hamrh added 1 commit

2026-04-30 14:12:01 +00:00

649-Footer-not-moving-whit-grid e425cc7025

-Set the totalRowHeight to rowHeight for a more dynamic gridsize.
-Changed the minRowsToFillScreen calculation to round down instead of up. This is to ensure the grid is not overlapping the footer.
-Moved gridSizes above totalRowHeight so we can use rowHeight whit it.

a24hamrh referenced this pull request

2026-04-30 14:12:38 +00:00

Footer not moving with grid #649

b24hugst commented

2026-04-30 14:23:32 +00:00

Collaborator

I think this also solved the issue I'm working with: #647

b24johka commented

2026-04-30 15:26:35 +00:00

Collaborator

Im guessing this not the way it should display?

when i am dragging a card down to increase the row the footer gets appropriate margin though

![image](/attachments/230ad142-52ca-4b16-9f09-4b2d61dab776) Im guessing this not the way it should display? ![image](/attachments/50d07a44-70f8-4c86-b616-0858ae632c3f) when i am dragging a card down to increase the row the footer gets appropriate margin though

image.png

66 KiB

image.png

78 KiB

b24hugst added 1 commit

2026-05-04 12:50:11 +00:00

Update grid at reset and deletion 1a64505615

Function now gets executed when deleting a card or reseting to default layout, which fixed the problem of the footer randomly being in the middle.

b24hugst commented

2026-05-04 12:51:39 +00:00

Collaborator

Noticed that the updateGridRows function never got executed when reseting or deleting a card, which made the footer appear in the middle of the page. That is now fixed.

a22erigr added the

Team 1

label

2026-05-04 13:23:34 +00:00

a24hamrh removed the

needs review

label

2026-05-04 13:37:55 +00:00

a24hamrh added 1 commit

2026-05-04 13:57:40 +00:00

Now the footer won’t overlap with the grid on initialization. 1dbe90812c

Removed the last row so it wont overlap whit the footer.
Round down the amount of rows the function for updating the grid on dragg was calculating.

a24hamrh added the

needs review

label

2026-05-04 13:58:02 +00:00

a24hirsa self-assigned this

2026-05-05 08:12:19 +00:00

a24hirsa commented

2026-05-05 08:16:36 +00:00

Collaborator

Code is well structured and follows our conventions well.

The Solution works on linux machines. The footer will move down as the grid grows without any overlap.

This is ready to be merged

Code is well structured and follows our conventions well. The Solution works on linux machines. The footer will move down as the grid grows without any overlap. This is ready to be merged

a24hirsa added

reviewed

and removed

needs review

labels

2026-05-05 08:16:47 +00:00