fix: make temperature graph preview fit add card view #719

Merged

a22erigr merged 1 commit from 693-fix-temperature-graph-preview-centering into team_2_week_4

2026-05-05 10:03:15 +00:00

b25marem commented

2026-05-04 14:06:04 +00:00

Collaborator

Fixes #693

Adjusted WeatherGraph to support configurable number of hours and reduced preview size so the graph fits and appears centered.

Fixes #693 Adjusted WeatherGraph to support configurable number of hours and reduced preview size so the graph fits and appears centered.

b25marem added 1 commit

2026-05-04 14:06:05 +00:00

fix: make temperature graph preview fit add card view 9586018da1

c24danli commented

2026-05-05 06:43:58 +00:00

Collaborator

I assume this is not reviewed so i will set the "needs reviewed"

👍 1

c24danli added the

needs review

label

2026-05-05 06:44:16 +00:00

a22erigr requested review from a24nedka

2026-05-05 07:25:51 +00:00

a24nedka commented

2026-05-05 08:37:25 +00:00

Collaborator

Review on #719

Whats done

Tested on Windows 11 using firefox

+Tested the TemperatureGraph preview in the “Add card” modal

App starts without problems
WeatherGraph is now centralized in add card view

Inspected following files

WeatherGraph.js
+No issues found with current implementation, follows project conventions.

+WeatherGraph.module.css

No issues found, current implementation follow the documentation.
TemperatureGraphView.js
- No issues found.

What needs to be done

The issue is fixed and it is centralized in addCard view. No need for a fix.

Conclusion

My conclusion is that it is ready for merge, works as it should, It is centralized.

# Review on #719 ## Whats done ### Tested on Windows 11 using firefox +Tested the TemperatureGraph preview in the “Add card” modal + App starts without problems + WeatherGraph is now centralized in add card view ### Inspected following files + WeatherGraph.js +No issues found with current implementation, follows project conventions. +WeatherGraph.module.css + No issues found, current implementation follow the documentation. + TemperatureGraphView.js + No issues found. ## What needs to be done The issue is fixed and it is centralized in addCard view. No need for a fix. ## Conclusion + My conclusion is that it is ready for merge, works as it should, It is centralized. ![image](/attachments/0bc558c7-4e82-451a-add4-cd8dd457a4ec)

image.png

103 KiB