Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 144 Pull requests 13 Projects Releases Packages Wiki Activity Actions 2

#691-move-ITempService-to-a-separate-file #755

Merged
a24julot merged 5 commits from #691-move-ITempService-to-a-separate-file into team_1_week_4 2026-05-06 07:23:12 +00:00
Conversation 3 Commits 5 Files changed 5 +14 -15
a23timgu commented 2026-05-05 13:00:52 +00:00
Collaborator
Copy link

A separate interface file has been created so the interface is not contained inside TempService.cs any longer.

Some unneeded 'using' statements were also commented out from related files. Can be removed instead of commented out if desired.

A separate interface file has been created so the interface is not contained inside TempService.cs any longer. Some unneeded 'using' statements were also commented out from related files. Can be removed instead of commented out if desired.
a24timsv requested changes 2026-05-05 13:25:24 +00:00
Dismissed
a24timsv left a comment
Collaborator
Copy link

The breakout of the interface is good, but having the unnecessary packages commented out will just result in them being there forever. It is better to delete them, and if they are needed again someone will reimplement them.

The breakout of the interface is good, but having the unnecessary packages commented out will just result in them being there forever. It is better to delete them, and if they are needed again someone will reimplement them.
a23timgu commented 2026-05-05 22:58:35 +00:00
Author
Collaborator
Copy link

The unnecessary packages have been escorted off the premises.

The unnecessary packages have been escorted off the premises.
a24timsv approved these changes 2026-05-06 07:12:34 +00:00
a24timsv left a comment
Collaborator
Copy link

I will omit the review template due to the simplicity of this review.

Looks good! Compiled it to test everything and nothing looks wrong.

I will omit the review template due to the simplicity of this review. Looks good! Compiled it to test everything and nothing looks wrong.
a24julot merged commit f1d9c1bb44 into team_1_week_4 2026-05-06 07:23:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24timsv
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!755
No description provided.