Added an error message when adding with no view selected #781

Merged

a22erigr merged 1 commit from 767-error-add-no-card-selected into team_2_week_5 2026-05-06 17:50:02 +00:00

Conversation 2 Commits 1 Files changed 1 +17 -4

b23albst commented 2026-05-06 12:12:29 +00:00

Collaborator

Copy link

A state is used to decide if error message should be shown or not (showError). It is set to true if add is pressed with nothing no view selected. It is set to false if a view is selected of the modal closed. Note: Clicking outside of the modal is not the same thing as closing it.

A state is used to decide if error message should be shown or not (showError). It is set to true if add is pressed with nothing no view selected. It is set to false if a view is selected of the modal closed. Note: Clicking outside of the modal is not the same thing as closing it.

b23albst added 1 commit 2026-05-06 12:12:30 +00:00

Added an error message when adding with no view selected 0118330746

b23albst added the

frontEnd

needs review

labels 2026-05-06 12:14:47 +00:00

c24danli 2026-05-06 14:05:31 +00:00

• added
  Under-review
  and removed
  needs review
  labels
• requested review from j21marbr

j21marbr commented 2026-05-06 14:34:12 +00:00

Collaborator

Copy link

Review on #781

Whats done

Tested on macOS using Chrome

• App starts
  • Verified that clicking "add" without selecting a view now shows an error message instead of a runtime error
  • Verified that the error message disappears correctly after selecting a view
  • Tested adding a card after selecting a view
    • Verified that the card is added as expected

Inspected following files

• AddCardModal.js
  • Indentation/code styling
    • Follows standard
  • Naming convention
    • Follows standard
  • Comments
    • Looks good
  • General code quality
    • No issues found, error handling works as expected

What needs to be done

• No issues found.

Conclusion

• Works as intended and the code is ready to be merged.

# Review on #781 ## Whats done ### Tested on macOS using Chrome + App starts + Verified that clicking "add" without selecting a view now shows an error message instead of a runtime error + Verified that the error message disappears correctly after selecting a view + Tested adding a card after selecting a view + Verified that the card is added as expected ### Inspected following files + AddCardModal.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + No issues found, error handling works as expected ## What needs to be done + No issues found. ## Conclusion + Works as intended and the code is ready to be merged.

j21marbr commented 2026-05-06 14:35:05 +00:00

Collaborator

Copy link

No description provided.

Screenshot.png

124 KiB

j21marbr added

reviewed

and removed

Under-review

labels 2026-05-06 14:36:08 +00:00

a22erigr merged commit e64f1bb100 into team_2_week_5 2026-05-06 17:50:02 +00:00

a22erigr referenced this pull request from a commit 2026-05-06 17:50:03 +00:00

Merge pull request 'Added an error message when adding with no view selected' (#781) from 767-error-add-no-card-selected into team_2_week_5

b23albst referenced this pull request 2026-05-06 19:28:38 +00:00

When pressing addcard without selecting a card a error occures #767

a22erigr referenced this pull request 2026-05-06 20:22:28 +00:00

When pressing addcard without selecting a card a error occures #767

b25marem referenced this pull request from a commit 2026-05-15 08:56:03 +00:00

Merge pull request 'Added an error message when adding with no view selected' (#781) from 767-error-add-no-card-selected into team_2_week_5

Sign in to join this conversation.

Reviewers

No reviewers

j21marbr

Labels

Clear labels   

_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  

API

  

app

  

backEnd

  

Blocked-waiting-for-further-changes

  

bug

Something is not working

  

bug-only-on-server-for-mobile-not-webpage

  

Bug-Report-After-Merge

  

cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  

close

Issue to close

  

design

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

feature request

  

frontEnd

  

further-changes-needed

  

future-problem-not-fixint-this-period

  

help wanted

Need some help

  

invalid

Something is wrong

  

last-week-issue-to-fix

  

library

  

low-priority

  

needs input

Issue needs input from product owner or customer

  

needs review

issue is in need of review

  

not-implemented.

  

project documentation

  

question

More information is needed

  

research

  

reviewed

This Issue has been reviewed

  

Script

  

security

use this for security-related issues

  

SQL

  

style

  

Team 1

Team 1 is responsible for this issue

  

Team 2

Team 2 is responsible for this issue

  

team leaders

  

test-creation

  

testing

  

topLevel

Reserved for top-level, project-wide issues.

  

unassigned

  

Under-review

  

wontfix

This won't be fixed

No labels

_CRITICAL_

API

app

backEnd

Blocked-waiting-for-further-changes

bug

bug-only-on-server-for-mobile-not-webpage

Bug-Report-After-Merge

cleanup

close

design

duplicate

enhancement

feature request

frontEnd

further-changes-needed

future-problem-not-fixint-this-period

help wanted

invalid

last-week-issue-to-fix

library

low-priority

needs input

needs review

not-implemented.

project documentation

question

research

reviewed

Script

security

SQL

style

Team 1

Team 2

team leaders

test-creation

testing

topLevel

unassigned

Under-review

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Andras/BoundlessFlowCampus2K!781

No description provided.