Fixed the Json creation #783

Merged

a22erigr merged 5 commits from #762-refactor-the-function-GetLayoutNameAndID(int-userID) into team_2_week_5

2026-05-07 08:00:37 +00:00

c24elipe commented

2026-05-06 12:33:18 +00:00

Collaborator

Implementation of tests in layoutService

On what device?

This has been developed on an Arch-based Linux distro and tested using dotnet tests.

What has been done?

The real change is in "service/layoutService/layoutService/Services/LayoutService.cs" and "service/layoutService/layoutService/Models/Response/LayoutNameResponse.cs". The latter was created as an object to be serialized to the JSON object. The Former had its "GetLayoutNameAndId" method to use the new object and use the JsonSerializer.Serialize method instead of building its own JSON from scratch. *
The rest of the files had just some light code clean up (many fixing incorrect spelling and indentation).

Issue:

#762

# Implementation of tests in layoutService ## On what device? This has been developed on an Arch-based Linux distro and tested using dotnet tests. ## What has been done? * The real change is in "**service/layoutService/layoutService/Services/LayoutService.cs**" and "**service/layoutService/layoutService/Models/Response/LayoutNameResponse.cs**". The latter was created as an object to be serialized to the JSON object. The Former had its "_GetLayoutNameAndId_" method to use the new object and use the JsonSerializer.Serialize method instead of building its own JSON from scratch. * * The rest of the files had just some light code clean up (many fixing incorrect spelling and indentation). ## Issue: #762

c24elipe added the

needs review

label

2026-05-06 12:33:18 +00:00

c24elipe added 4 commits

2026-05-06 12:33:19 +00:00

Fixed the Json creation 8860edb270

Undid bad refactor fb5b0ded26

Git hats me so here is the real commit 9d7260f1cd

Fixed bad error message b52a16252c

a24nedka requested review from a24nedka

2026-05-06 15:09:26 +00:00

a22erigr added 1 commit

2026-05-06 19:25:10 +00:00

Fixed indentation 2f81c77c1b

a24nedka commented

2026-05-06 22:02:08 +00:00

Collaborator

Review on #783

Tested on Windows using dotnet test

Verified that the issue requirement (removal of manual JSON construction) is fulfilled.
Confirmed that GetLayoutNameAndId now uses JsonSerializer.Serialize instead of manually building a JSON string.
Ran all tests using dotnet test and all tests passed.
Manual JSON construction has been replaced with proper serialization using JsonSerializer, improving code clarity and reducing risk of errors.

Inspected following files LayoutService.cs , LayoutNameResponse.cs

Inspected these 2 files.
- Indentation/code styling
  - Indentation is OK.
Naming convention
- Naming convention is followed.
Comments
- Enough comments to understand.
General code quality
- Code is cleaner after refactor and follows standard.
- Uses JsonSerializer instead of manual JSON construction.

What needs to be done

Nothing for now.

Conclusion

My conclusion is that the issue is solved, and functionality works as expected.

# Review on #783 ### Tested on Windows using dotnet test + Verified that the issue requirement (removal of manual JSON construction) is fulfilled. + Confirmed that GetLayoutNameAndId now uses JsonSerializer.Serialize instead of manually building a JSON string. + Ran all tests using dotnet test and all tests passed. + Manual JSON construction has been replaced with proper serialization using JsonSerializer, improving code clarity and reducing risk of errors. ### Inspected following files **LayoutService.cs** , LayoutNameResponse.cs + Inspected these 2 files. + Indentation/code styling + Indentation is OK. + Naming convention + Naming convention is followed. + Comments + Enough comments to understand. + General code quality + Code is cleaner after refactor and follows standard. + Uses JsonSerializer instead of manual JSON construction. ## What needs to be done Nothing for now. ## Conclusion My conclusion is that the issue is solved, and functionality works as expected.

a24nedka added

reviewed

and removed

needs review

labels

2026-05-06 22:02:27 +00:00