Andras/BoundlessFlowCampus2K

Fork 0

#789-Socials-Page #792

Merged

a24julot merged 4 commits from #789-Socials-Page into team_1_week_5

2026-05-08 07:16:19 +00:00

a24hirsa commented

2026-05-07 07:02:36 +00:00

Collaborator

Added a social page that the footer social button links to. Only the page has been added with no fucntional links to School socials, that will be a seperate issue

Originial issue is #789 #789

Added a social page that the footer social button links to. Only the page has been added with no fucntional links to School socials, that will be a seperate issue Originial issue is #789 https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/789

a24hirsa added 3 commits

2026-05-07 07:02:37 +00:00

Add empty directory using .gitkeep 787ea4bbe5

Incorrect pathing 9451f1d823

added a page for socials that the footer button links to c2b572d43d

a24hirsa added the

needs review

label

2026-05-07 07:08:38 +00:00

a24hirsa commented

2026-05-07 07:09:11 +00:00

Author

Collaborator

Scrolling to the top on click is being fixed in a separate issue by b23albst

a24julot requested review from b24krila

2026-05-07 12:47:48 +00:00

b24krila added the

Under-review

label

2026-05-07 13:07:53 +00:00

b24krila commented

2026-05-07 13:28:47 +00:00

Collaborator

Review on #792

What has been Done.

Reviewed the code and tested if the socials page exists and is reachable

Tested on Windows Using Microsoft Edge and Google Chrome

App starts
Footer is visible and can be interacted with
The placeholder takes you to the socials page.
Found the issue that is being worked on by b23albst

Inspected the following files "App.js" , "Footer.js", "Socials.js", "index.js"

The code is following our standards

What needs to be done

Nothing

Question

In this pull-request there seems to be included files that do not correlate to the current issue:
- frontend/src/components/Graphs/WeatherGraph.js
- scripts/deployment/Deploy.sh
My question is are these supposed to be here or is there a mistake because otherwise I see no problems.

Conclusion

In conclusion the issue seems to have been solved the pull-request is a bit weird but after an answer the issue can be merged without and problems.

### Review on #792 ### What has been Done. Reviewed the code and tested if the socials page exists and is reachable ### Tested on Windows Using Microsoft Edge and Google Chrome - App starts - Footer is visible and can be interacted with - The placeholder takes you to the socials page. - Found the issue that is being worked on by b23albst ### Inspected the following files "App.js" , "Footer.js", "Socials.js", "index.js" - The code is following our standards ### What needs to be done - Nothing ### Question - In this pull-request there seems to be included files that do not correlate to the current issue: - frontend/src/components/Graphs/WeatherGraph.js - scripts/deployment/Deploy.sh - My question is are these supposed to be here or is there a mistake because otherwise I see no problems. ### Conclusion In conclusion the issue seems to have been solved the pull-request is a bit weird but after an answer the issue can be merged without and problems.

b24krila added

reviewed

question

and removed

needs review

labels

2026-05-07 13:28:52 +00:00

a24hirsa added 1 commit

2026-05-07 13:46:25 +00:00

Update Deploy.sh 81dbee82a0

a24hirsa commented

2026-05-07 13:50:31 +00:00

Author

Collaborator

Deploy changes was never intentionally made but seemed to have happened for some reason and weather graph is one to one with already existing weather graph in the team branch.

My guess is that the deploy change and showing of weather graph as beign brand new is just github and vscode hallucinations caused by me only doing a fetch on main and not on the team branch in specific before creating this branch. I reverted the deploy change as that actually removed code. But the Weather graph is 1 to 1 so it should be fine as long as there are no merge conflicts. But try to make note of this branch if any future troubles happen with the temperature graph or deployment just in case.

Deploy changes was never intentionally made but seemed to have happened for some reason and weather graph is one to one with already existing weather graph in the team branch. My guess is that the deploy change and showing of weather graph as beign brand new is just github and vscode hallucinations caused by me only doing a fetch on main and not on the team branch in specific before creating this branch. I reverted the deploy change as that actually removed code. But the Weather graph is 1 to 1 so it should be fine as long as there are no merge conflicts. But try to make note of this branch if any future troubles happen with the temperature graph or deployment just in case.

a24julot merged commit 20e8cacb2e into team_1_week_5

2026-05-08 07:16:19 +00:00

a24julot referenced this pull request from a commit

2026-05-08 07:16:22 +00:00

Merge pull request '#789-Socials-Page' (#792) from #789-Socials-Page into team_1_week_5