Andras/BoundlessFlowCampus2K

Fork 0

776-hide-toolbar-button #794

Merged

a24julot merged 5 commits from 776-hide-toolbar-button into team_1_week_5

2026-05-07 08:52:11 +00:00

b24erika commented

2026-05-07 07:13:50 +00:00

Collaborator

The toolbar can now be hidden so that a user can use the "entire" view container once they are happy with their layout.

b24erika added the

frontEnd

Team 1

needs review

labels

2026-05-07 07:13:50 +00:00

b24erika self-assigned this

2026-05-07 07:13:50 +00:00

b24erika added 5 commits

2026-05-07 07:13:51 +00:00

initial commit hide toolbar 50da5a0ac2

new way of hiding toolbar 53714e7166

translate impacts the reset layout "prompt" making it now clickable in certain cases and can not be fixed with z-index, new approach but does not look as good.

fine-tuning css a65c06dee5

removed position 9333a5c156

caused the button to move with the screen while scrolling

added comments 396b252949

b24erika referenced this pull request

2026-05-07 07:17:25 +00:00

Implement a button/arrow to toggle the toolbar #776

a24julot

2026-05-07 07:59:27 +00:00

added
Under-review
and removed
needs review
labels
requested review from b24hugst

b24hugst commented

2026-05-07 08:34:53 +00:00

Collaborator

Review on #776

Whats done

Looked over code and result on website

Tested on Windows 11 using Chrome

App starts
- The function works and I couldn't find it breaking anything else.

Inspected following files:

Dashboard.js
Dashboard.module.css
- Indentation/code styling is ok
- Naming convention looks good
- Comments follows standard
- General code quality looks good

What needs to be done

Make button hit the corners or just look more natural somehow.

Conclusion

Everything looks good functionality- and code wise, but I think that the button needs to be longer to hit the corners. Although kind of hard to do since the dashboard is rounded at the sides.

# Review on #776 ## Whats done Looked over code and result on website ### Tested on Windows 11 using Chrome + App starts + The function works and I couldn't find it breaking anything else. ### Inspected following files: + Dashboard.js + Dashboard.module.css + Indentation/code styling is ok + Naming convention looks good + Comments follows standard + General code quality looks good ## What needs to be done Make button hit the corners or just look more natural somehow. ## Conclusion + Everything looks good functionality- and code wise, but I think that the button needs to be longer to hit the corners. Although kind of hard to do since the dashboard is rounded at the sides. + ![image](/attachments/27bc141b-4996-4166-a997-55e2bc26f329)

image.png

14 KiB

b24hugst added

reviewed

and removed

Under-review

labels

2026-05-07 08:39:31 +00:00

b24erika commented

2026-05-07 08:46:13 +00:00

Author

Collaborator

Thanks for the review @b24hugst!

I made it shorter on purpose since it is rounded as mentioned, perhaps something that needs to be discussed with the customer before making any changes or do you think that it needs to be done before it could be merged?

Thanks for the review @b24hugst! I made it shorter on purpose since it is rounded as mentioned, perhaps something that needs to be discussed with the customer before making any changes or do you think that it needs to be done before it could be merged?

b24hugst commented

2026-05-07 08:48:35 +00:00

Collaborator

@b24erika Yeah that's true actually talking with the customer first before is probably more wise. So since it's just pure styling differences and the functionality works this is ready to be merged.

a24julot commented

2026-05-07 08:52:00 +00:00

Collaborator

This PR will be merged and the matters you discussed will be brought up with the customer today. If further changes needs to be made, there will be a new issue on that!

a24julot merged commit 3d3c2459e8 into team_1_week_5

2026-05-07 08:52:11 +00:00

a24julot referenced this pull request from a commit

2026-05-07 08:52:13 +00:00

Merge pull request '776-hide-toolbar-button' (#794) from 776-hide-toolbar-button into team_1_week_5