Andras/BoundlessFlowCampus2K

Fork 0

#779-fix-map-view-scaling #806

Merged

a22erigr merged 2 commits from 779-fix-scaling-map-view into team_2_week_5

2026-05-07 13:59:10 +00:00

j21marbr commented

2026-05-07 09:14:46 +00:00

Collaborator

Changes:
Updated the map view scaling to keep the svg proportions when resizing the card.

Changes: Updated the map view scaling to keep the svg proportions when resizing the card.

j21marbr added 1 commit

2026-05-07 09:14:47 +00:00

Fix map view scaling 3e6aae9841

j21marbr commented

2026-05-07 09:14:59 +00:00

Author

Collaborator

No description provided.

bild.png

60 KiB

j21marbr added the

needs review

label

2026-05-07 09:15:09 +00:00

j21marbr referenced this pull request

2026-05-07 09:15:35 +00:00

We need to fix the scaling of map-view #779

a22erigr

2026-05-07 09:46:19 +00:00

added the
Under-review
label
requested review from b24idalu

b24idalu requested changes

2026-05-07 10:21:19 +00:00

b24idalu left a comment

Collaborator

Review on #779

Whats done

Implement so that the indented proportion are kept regardless of size.

Tested on Windows using Chrome & Firefox

App starts
- Everything still works like normally.
- Tested the new map view, it still launches like normally. The map now has one size, no matter how big the card is. See picture,

Inspected following files

frontend/src/features/map/MapView.js
- Indentation/code styling
  - Follows prettier.
- Naming convention
  - No new files/variables.
- Comments
  - No new comments needed.
- General code quality
  - Nothing to mention, still looks good.

What needs to be done

frontend/src/features/map/MapView.js
- The solution does not meet the requirements. The map is always one size and does not scale with the card.

Conclusion

I believe what was meant with the issue was to always keep the same proportion on the room squares, but still let the map scale with the card. The solution does not do this, and is therefore not ready to be merged.

![image](/attachments/c567d359-bc0a-4f37-9f7c-a88c587143d3) # Review on #779 ## Whats done Implement so that the indented proportion are kept regardless of size. ### Tested on Windows using Chrome & Firefox + App starts + Everything still works like normally. + Tested the new map view, it still launches like normally. The map now has one size, no matter how big the card is. See picture, ### Inspected following files + frontend/src/features/map/MapView.js + Indentation/code styling + Follows prettier. + Naming convention + No new files/variables. + Comments + No new comments needed. + General code quality + Nothing to mention, still looks good. ## What needs to be done + frontend/src/features/map/MapView.js + The solution does not meet the requirements. The map is always one size and does not scale with the card. ## Conclusion + I believe what was meant with the issue was to always keep the same proportion on the room squares, but still let the map scale with the card. The solution does not do this, and is therefore not ready to be merged.

image.png

14 KiB

a22erigr commented

2026-05-07 10:35:39 +00:00

Collaborator

@j21marbr Can you fix the issues found in review?

j21marbr commented

2026-05-07 10:44:58 +00:00

Author

Collaborator

Yes I will fix it

👍 1

j21marbr added 1 commit

2026-05-07 13:05:01 +00:00

Update svg scaling 9b27aa1c60

j21marbr commented

2026-05-07 13:06:51 +00:00

Author

Collaborator

No description provided.

bild1.png

172 KiB

a22erigr requested review from a24nedka

2026-05-07 13:09:04 +00:00

a24nedka commented

2026-05-07 13:49:18 +00:00

Collaborator

I have reviewed the fix. The problem was that the map didn't scale well with the card. The problem is now solved and in my opinion it scales well for now, I could not find any issues. My opinion is that the problem is solved now. Look at the screenshots down below. ![image](/attachments/5615835f-132f-404b-a5df-645c0d552707)![image](/attachments/eb66bd67-574b-4f97-b625-aceb59f41dfa)

image.png

36 KiB

image.png

45 KiB

👍 1