Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#799 Fix mobile preview header #819

Merged
a22erigr merged 3 commits from #799-Fix-mobile-preview-header into team_2_week_5 2026-05-08 10:51:58 +00:00
Conversation 3 Commits 3 Files changed 1 +11 -1
b24idalu commented 2026-05-07 13:13:51 +00:00
Collaborator
Copy link

Regarding issue #799: Fix mobile preview header.

Problems: 1. Header in the preview window of the add card modal creates less space for the actual preview.

Solution: 1. Downsized the header and removed the view name as per suggestion. Since the preview got placed differently depending on the size of the card, the display area got smaller by removing some margin from elements.

Possible improvements:

  • Header still moves a bit depending on the card size, if the preview card is made smaller it does not show information however. Do not know how to fix.

Notes: Tested through Chromes "phone view".

Regarding issue #799: Fix mobile preview header. Problems: 1. Header in the preview window of the add card modal creates less space for the actual preview. Solution: 1. Downsized the header and removed the view name as per suggestion. Since the preview got placed differently depending on the size of the card, the display area got smaller by removing some margin from elements. Possible improvements: - Header still moves a bit depending on the card size, if the preview card is made smaller it does not show information however. Do not know how to fix. Notes: Tested through Chromes "phone view".
Removed and resized stuff to make the card fit better.
Removed some margin for the card.
j21marbr commented 2026-05-07 15:39:14 +00:00
Collaborator
Copy link

Review on #819

Whats done

Tested on both Iphone (safari) and macOS using chrome phone view

  • App starts
    • Opened the add card modal
    • Verified that preview header now takes less space
    • Checked that the preview area has more room for content

Inspected following files

  • AddCardModal.module.css
    • Indentation/code styling
      • Follows standard
    • Naming convention
      • Follows standard
    • General code quality
      • The mobile preview layout is improved but additional fixes are needed.

What needs to be done

  • Fix preview content being hidden on smaller mobile preview sizes.

Conclusion

The changes improve the mobile preview layout and reduce the space used by the header. However some preview content becomes hidden on smaller preview sizes.

# Review on #819 ## Whats done ### Tested on both Iphone (safari) and macOS using chrome phone view + App starts + Opened the add card modal + Verified that preview header now takes less space + Checked that the preview area has more room for content ### Inspected following files + AddCardModal.module.css + Indentation/code styling + Follows standard + Naming convention + Follows standard + General code quality + The mobile preview layout is improved but additional fixes are needed. ## What needs to be done + Fix preview content being hidden on smaller mobile preview sizes. ## Conclusion The changes improve the mobile preview layout and reduce the space used by the header. However some preview content becomes hidden on smaller preview sizes.
j21marbr commented 2026-05-07 15:40:13 +00:00
Collaborator
Copy link
No description provided.
IMG_7621.jpg
212 KiB
IMG_7620.jpg
201 KiB
IMG_7621.jpg IMG_7620.jpg 
Fixed some content not being shown.
j21marbr commented 2026-05-08 10:05:18 +00:00
Collaborator
Copy link

Good job. I tested on Iphone (safari) and macOS using chrome phone view. The hidden content issue is now fixed and the code is ready to be merged.

Good job. I tested on Iphone (safari) and macOS using chrome phone view. The hidden content issue is now fixed and the code is ready to be merged.
a22erigr merged commit 53fd710016 into team_2_week_5 2026-05-08 10:51:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
j21marbr
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b24idalu
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!819
No description provided.