Andras/BoundlessFlowCampus2K

Fork 0

662-solution-file-is-not-up-to-date #826

Merged

a22erigr merged 3 commits from 662-solution-file-is-not-up-to-date into team_2_week_5

2026-05-11 11:51:40 +00:00

a24nedka commented

2026-05-07 21:34:41 +00:00

Collaborator

So I implemented two scripts, one for Windows and one with bash.

When running the scripts, the BoundlessFlowCampus2K.slnx file is updated with all existing .csproj files in the project.

I also implemented support for removing deleted projects. If a project folder has been removed, running the script again will automatically update the .slnx file and remove the missing project reference.

Files added:

UnixUpdateSolution.sh

WindowsUpdateSolution.bat
Issue #662

So I implemented two scripts, one for Windows and one with bash. When running the scripts, the BoundlessFlowCampus2K.slnx file is updated with all existing .csproj files in the project. I also implemented support for removing deleted projects. If a project folder has been removed, running the script again will automatically update the .slnx file and remove the missing project reference. Files added: **UnixUpdateSolution.sh** **WindowsUpdateSolution.bat** Issue #662

a24nedka added 2 commits

2026-05-07 21:34:41 +00:00

WindowsUpdateSolution.bat 3a68313316

Script to add csproj to slnx

Script UnixUpdateSolution.sh b6193f9338

Added script for Linux/Mac same as the one for Windows

a24nedka added the

needs review

label

2026-05-07 21:36:38 +00:00

a22erigr requested review from c24elipe

2026-05-08 07:07:33 +00:00

a22erigr changed title from ~~662-solution-file-is-not-up-to-date~~ to WIP: 662-solution-file-is-not-up-to-date

2026-05-08 07:07:42 +00:00

a22erigr added the

Under-review

label

2026-05-08 07:07:57 +00:00

c24elipe requested changes

2026-05-08 11:15:59 +00:00

c24elipe left a comment

Collaborator

Review on issue #628, PR #826

Whats done

Tested on CachyOS (Arch Linux)

The Linux version of the script runs as intended.

Inspected the Windows version by assuming it would work and just checking it against the conventions set.

Inspected the following files

scripts/UnixUpdateSolution.sh:
- Indentation/code styling:
  - The indentation rules are followed. However, some problems, as shown below, are present.
- Naming convention:
  - Overall good, except the variable "cleanPath" should be renamed "clean_path" to follow the coding conventions rule of using snake_case.
- Comments:
  - They exist and are good.
- General code quality:
  - This is petty, but the line "dotnet sln BoundlessFlowCampus2K.slnx list | grep ".csproj" | while read -r project" doesn't follow the coding conventions rule of each line being max 80 characters long. That line is 83. '
  - Another point is that each shell script should start with the following snippet. It's that empty comment line that is missing.

#!/bin/bash
# <---- This is missing.
# This script updates the solution file with all existing .csproj files

scripts/WindowsUpdateSolution.bat:
- Indentation/code styling:
  - It uses 4-space indentation and looks good to me. Also, no spacing after comments 👍
- Naming convention:
  - Again, the naming conversion is followed nicely (since we now use camelCase for some reason, for bat files)
- Comments:
  - Again, exists and are good.
- General code quality:
  - Assuming the script works, I can't find anything that goes against the conventions, so look good 👍

What needs to be done

"dotnet sln BoundlessFlowCampus2K.slnx list | grep ".csproj" | while read -r project" could be shortened with either a variable, or just broken up in two lines, as the following example shows.

# Option 1:
sln="BoundlessFlowCampus2K.slnx"
dotnet sln "$sln" list | grep ".csproj" | while read -r project

# Option 2:
dotnet sln BoundlessFlowCampus2K.slnx list | grep ".csproj" | \
  while read -r project

The space in the header of the file should be filled as shown.

#!/bin/bash
# <---- This is missing.
# This script updates the solution file with all existing .csproj files

Conclusion

Minus two quick fixes, the Linux version does what it should be doing, and it works.
Someone should run the Windows version before merging.

It should, in other words, not be merged for the moment

# Review on issue #628, PR #826 ## Whats done ### Tested on CachyOS (Arch Linux) * The Linux version of the script runs as intended. ![image](/attachments/8c0f2c25-72f9-493e-ac91-9285bce6c803) * Inspected the Windows version by assuming it would work and just checking it against the conventions set. ## Inspected the following files * **scripts/UnixUpdateSolution.sh**: * **Indentation/code styling**: * The indentation rules are followed. However, some problems, as shown below, are present. * **Naming convention**: * Overall good, except the variable "cleanPath" should be renamed "clean_path" to follow the coding conventions rule of using snake_case. * **Comments**: * They exist and are good. * **General code quality**: * This is petty, but the line **"dotnet sln BoundlessFlowCampus2K.slnx list | grep ".csproj" | while read -r project"** doesn't follow the coding conventions rule of each line being max 80 characters long. That line is 83. ' * Another point is that each shell script should start with the following snippet. It's that empty comment line that is missing. ```bash #!/bin/bash # <---- This is missing. # This script updates the solution file with all existing .csproj files ``` * **scripts/WindowsUpdateSolution.bat**: * **Indentation/code styling**: * It uses 4-space indentation and looks good to me. Also, no spacing after comments 👍 * **Naming convention**: * Again, the naming conversion is followed nicely (since we now use camelCase for some reason, for bat files) * **Comments**: * Again, exists and are good. * **General code quality**: * Assuming the script works, I can't find anything that goes against the conventions, so look good 👍 ## What needs to be done * **"dotnet sln BoundlessFlowCampus2K.slnx list | grep ".csproj" | while read -r project"** could be shortened with either a variable, or just broken up in two lines, as the following example shows. ```bash # Option 1: sln="BoundlessFlowCampus2K.slnx" dotnet sln "$sln" list | grep ".csproj" | while read -r project # Option 2: dotnet sln BoundlessFlowCampus2K.slnx list | grep ".csproj" | \ while read -r project ``` * The space in the header of the file should be filled as shown. ```bash #!/bin/bash # <---- This is missing. # This script updates the solution file with all existing .csproj files ``` ## Conclusion Minus two quick fixes, the Linux version does what it should be doing, and it works. Someone should run the Windows version before merging. It should, in other words, **not be merged** for the moment

image.png

240 KiB

a22erigr changed title from ~~WIP: 662-solution-file-is-not-up-to-date~~ to 662-solution-file-is-not-up-to-date

2026-05-08 12:43:03 +00:00

a24nedka added 1 commit

2026-05-08 13:37:27 +00:00

update UnixUpdateSolution.sh d0c514377a

Fixed the reviewers feedback

a24nedka commented

2026-05-08 13:39:01 +00:00

Author

Collaborator

Renamed cleanPath -> clean_path and fixed the other two suggestions

b24idalu commented

2026-05-11 08:42:46 +00:00

Collaborator

Review on #628, PR #826

Whats done

[Review following things]

Tested on Windows

The Windows version of the script runs as intended.
Inspected changes made since last review

Inspected following files [IMPORTANT!, Don't forget to inspect for unapproved dependencies in package.json ]

scripts/UnixUpdateSolution.sh
- Indentation/code styling
  - Looks good
- Naming convention
  - Variable name has been updated to match convention.
- Comments
  - Still looks good.
- General code quality
  - There is no longer a line that is 80 characters long.
  - Commented out line has been added to the start of the file to follow convention.
    +scripts/WindowsUpdateSolution.bat
- Indentation/code styling
  - Looks good.
- Naming convention
  - Looks good.
- Comments
  - Still looks good.
- General code quality
  - Looks good.

What needs to be done

Nothing.

Conclusion

Everything looks good, ready to merge.

# Review on #628, PR #826 ## Whats done [Review following things] ### Tested on Windows + The Windows version of the script runs as intended. + Inspected changes made since last review ### Inspected following files [IMPORTANT!, Don't forget to inspect for unapproved dependencies in **package.json** ] + scripts/UnixUpdateSolution.sh + Indentation/code styling + Looks good + Naming convention + Variable name has been updated to match convention. + Comments + Still looks good. + General code quality + There is no longer a line that is 80 characters long. + Commented out line has been added to the start of the file to follow convention. +scripts/WindowsUpdateSolution.bat + Indentation/code styling + Looks good. + Naming convention + Looks good. + Comments + Still looks good. + General code quality + Looks good. ## What needs to be done Nothing. ## Conclusion + Everything looks good, ready to merge.

a22erigr merged commit 32911419c4 into team_2_week_5

2026-05-11 11:51:40 +00:00

a22erigr referenced this pull request from a commit

2026-05-11 11:51:42 +00:00

Merge pull request '662-solution-file-is-not-up-to-date' (#826) from 662-solution-file-is-not-up-to-date into team_2_week_5