Andras/BoundlessFlowCampus2K

Fork 0

798-add-card-horizontal-fix #832

Merged

a22erigr merged 5 commits from 798-add-card-horizontal-fix into team_2_week_5

2026-05-11 07:03:18 +00:00

b23albst commented

2026-05-08 07:36:07 +00:00

Collaborator

What's been done

Changed the css for the add card modal to take into account when a phone is held in landscape mode. This is done with a media query and removing some parts of the component.

I tested this with the firefox mobile view and on my own phone (samsung s9 I think) and it looked good on them, but please try it on your own phone.

# What's been done Changed the css for the add card modal to take into account when a phone is held in landscape mode. This is done with a media query and removing some parts of the component. I tested this with the firefox mobile view and on my own phone (samsung s9 I think) and it looked good on them, but please try it on your own phone. ![image](/attachments/c2eb5d4f-8dca-4c06-bff6-c5382bdf0eaa)

image.png

67 KiB

b23albst added 3 commits

2026-05-08 07:36:07 +00:00

Added css for landscape mode. Breaking point might need to be changed 73cf2eedbb

minor changes db8433feaf

Decided to re-add the categories afe7588d01

b23albst added the

frontEnd

needs review

labels

2026-05-08 07:36:28 +00:00

a22erigr commented

2026-05-08 11:02:02 +00:00

Collaborator

When reviewing don't forget to merge Team_2_week_5 into this branch and resolve the conflict. Merge team2-> this branch. Not this branch -> week branch

b23albst added 1 commit

2026-05-08 20:42:11 +00:00

Merged team 2 branch into this one and fixed issues 251d7d9dc5

b23albst added 1 commit

2026-05-08 21:05:36 +00:00

Made sure errors are displayed correctly and do not overflow 43b21b4eaf

b23albst commented

2026-05-08 21:06:38 +00:00

Author

Collaborator

I merged the team 2 branch into this one and made sure the changes to add card modal were compatible.

I merged the team 2 branch into this one and made sure the changes to add card modal were compatible. ![image](/attachments/a9bfc7c3-29b4-492c-b03b-e368ccbfb56f) ![image](/attachments/8a5d721a-ab9f-4597-b7b2-c19efa8cc032)

image.png

44 KiB

image.png

48 KiB

a22erigr

2026-05-09 08:43:25 +00:00

added the
Under-review
label
requested review from c22abdal

c22abdal commented

2026-05-09 11:24:17 +00:00

Collaborator

Tested id on my own phone using the Safari browser, and it is responsive and compatible.

The changes you made are overall good and working as they should.
Nice touch with the comments to explain your work and others!

No code standards violations as much as I could see. Follows Prettier.

Can be merged!

Tested id on my own phone using the Safari browser, and it is responsive and compatible. ![image](/attachments/61cfb07c-cfa1-4769-888f-1b3f19c74970) The changes you made are overall good and working as they should. Nice touch with the comments to explain your work and others! No code standards violations as much as I could see. Follows Prettier. Can be merged!

image.png

437 KiB