Update error messages in temperature views #849
No reviewers
a24sakma
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!849
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "837-temperature-error-messages-team1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Recreated the solution from the correct team branch (team_1_week_5) to avoid future merge conflicts.
Changes:
Moved the implementation to a branch based on team 1’s weekly branch
Resolved merge conflicts with team 1’s latest temperature card functionality
Updated error and empty-state messages to use the selected month/year variables
Preserved the new navigation functionality for changing month and year
As this was reviewed in the previous branch I approve this changes.
The only thing that should change is the error message in the p tag. But it seems there is a lot of changes. If statements that were removed from our branch is on this branch, did you pull the latest version from our branch @b25marem ?
You’re right, more changes than intended were carried over when I recreated the branch, which made the diff larger than expected. I’ll clean up the PR so it only contains the intended error message updates.
I cleaned up the PR and removed the unrelated changes.
Now the PR only contains the updated error messages in the temperature views.
#833 (comment)
Good job, the code does what it is supposed to do, ready to be merged.