Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#853Replace hamburger menu to buttons #875

Merged
a22erigr merged 2 commits from 853-change-hamburger-menu-to-buttons into team_2_week_5 2026-05-12 07:37:16 +00:00
Conversation 5 Commits 2 Files changed 5 +71 -157
a24nedka commented 2026-05-11 09:24:42 +00:00
Collaborator
Copy link

Removed the hamburger menu and replaced it with two navigation buttons using Material Design icons.

Added:

  • Settings button
  • User button

Updated styling to support both light and dark themes using existing theme variables.
Changed two files HamburgerMenu.js and HamburgerMenu.module.css
Implemented Material design icons as requested.

Issue #853

imageimage

Removed the hamburger menu and replaced it with two navigation buttons using Material Design icons. Added: - Settings button - User button Updated styling to support both light and dark themes using existing theme variables. Changed two files **HamburgerMenu.js** and **HamburgerMenu.module.css** Implemented Material design icons as requested. Issue #853 ![image](/attachments/b4055593-f115-4d64-9f0a-711673495b18)![image](/attachments/8b8a9cd9-92ca-4c09-a57d-a9b8dc8ff812)
image.png
60 KiB
image.png
56 KiB 
Removed the hamburger menu and replaced it with two navigation buttons using Material Design icons.

Added:
- Settings button
- User button

Updated styling to support both light and dark themes using existing theme variables.
a24nedka changed title from "853Replace hamburger menu to buttons to #853Replace hamburger menu to buttons 2026-05-11 09:25:31 +00:00
a22erigr commented 2026-05-11 09:37:52 +00:00
Collaborator
Copy link

What are the new dependencies

What are the new dependencies
a24nedka commented 2026-05-11 09:45:00 +00:00
Author
Collaborator
Copy link

@a22erigr
Added @mui/icons-material for Material Design icons.

@a22erigr Added @mui/icons-material for Material Design icons.
c24danli commented 2026-05-11 09:45:51 +00:00
Collaborator
Copy link

It seams that we import the icons, but as we dont use that many we prefer downloading the svg icons from
https://fonts.google.com/icons?icon.size=24&icon.color=%231f1f1f
This would keep the dependencies down and keep the code from bloating.

It seams that we import the icons, but as we dont use that many we prefer downloading the svg icons from https://fonts.google.com/icons?icon.size=24&icon.color=%231f1f1f This would keep the dependencies down and keep the code from bloating. 
Replaced imported MUI icons with local SVG icons
- Removed unused dependencies from last comit
- Updated styling to follow current CSS conventions
j21marbr commented 2026-05-12 07:35:27 +00:00
Collaborator
Copy link

Review on #875

Whats done

Tested on macOS using Chrome

  • App starts
    • Verifed that the hamburger menu is replaced with navigation icon buttons
    • Tested both settings and user buttons
    • Verified that the styling works in both light and dark mode

Inspected following files

  • HamburgerMenu.js
    • Indentation/code styling
      • Follows standard
    • Naming convention
      • Follows standard
    • Comments
      • Looks good
    • General code quality
      • Cleanup looks good after replacing MUI icons with local SVG icons
  • HamburgerMenu.module.css
    • Indentation/code styling
      • Follows standard
    • Naming convention
      • Follows standard
    • Comments
      • Looks good
    • General code quality
      • No issues found, hover effects and theme variables work correctly

What needs to be done

  • No issues found

Conclusion

  • Works as intended and the code is ready to be merged.
# Review on #875 ## Whats done ### Tested on macOS using Chrome + App starts + Verifed that the hamburger menu is replaced with navigation icon buttons + Tested both settings and user buttons + Verified that the styling works in both light and dark mode ### Inspected following files + HamburgerMenu.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + Cleanup looks good after replacing MUI icons with local SVG icons + HamburgerMenu.module.css + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + No issues found, hover effects and theme variables work correctly ## What needs to be done + No issues found ## Conclusion + Works as intended and the code is ready to be merged.
a22erigr merged commit 634eb09763 into team_2_week_5 2026-05-12 07:37:16 +00:00
j21marbr commented 2026-05-12 07:38:00 +00:00
Collaborator
Copy link
No description provided.
bild1.png
74 KiB
bild2.png
91 KiB
bild1.png bild2.png
Sign in to join this conversation.
Reviewers
No reviewers
j21marbr
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!875
No description provided.