#658 Converted options to string #888

Merged

a22erigr merged 3 commits from #658-Options-dependenacy into team_2_week_5 2026-05-13 08:25:25 +00:00

Conversation 7 Commits 3 Files changed 1 +9 -2

c22abdal commented 2026-05-11 12:08:41 +00:00

Collaborator

Copy link

Converting the options to a string stabilizes it and can be passed safely as a dependency.

Converting the options to a string stabilizes it and can be passed safely as a dependency.

c22abdal added the

needs review

label 2026-05-11 12:08:41 +00:00

c22abdal added 1 commit 2026-05-11 12:08:42 +00:00

Converted options to string ... d694d120ef

Converting the options to a string stabilizes it and can be passed safely as a dependency.

c24danli changed title from Converted options to string to #658 Converted options to string 2026-05-12 10:56:36 +00:00

c24danli 2026-05-12 11:05:53 +00:00

• removed the
  needs review
  label
• requested review from c24elipe

c24elipe commented 2026-05-12 11:19:41 +00:00

Collaborator

Copy link

Review on issue #885, PR #912

Whats done

Tested on Arch Linux, and Firefox

• Compile the application to check that it works.
• Check the logs that the warning is gone... it wasn't
  
• Inspected the file.
• Run and make sure it still works by using the frontend.

Inspected the following files

• frontend/src/features/utility/sharedFeatures.js
  • Indentation/code styling:
    • It follows prettier.
  • Naming convention
    • It is followed
  • Comments
    • Exist and are good
  • General code quality
    • Minus the error that is still there. It is good.

What needs to be done

After some discussion with @c24danli, the warning shown in the image needs to be addressed.

Also, fixing the merge conflict needs to be done.

Conclusion

For the moment, I don't recommend merging.

# Review on issue #885, PR #912 ## Whats done ### Tested on Arch Linux, and Firefox * Compile the application to check that it works. * Check the logs that the warning is gone... it wasn't  * Inspected the file. * Run and make sure it still works by using the frontend. ### Inspected the following files * **frontend/src/features/utility/sharedFeatures.js** * **Indentation/code styling**: * It follows prettier. * **Naming convention** * It is followed * **Comments** * Exist and are good * **General code quality** * Minus the error that is still there. It is good. ## What needs to be done After some discussion with @c24danli, the warning shown in the image needs to be addressed.  Also, fixing the merge conflict needs to be done. ## Conclusion For the moment, I don't recommend merging.

image.png

9.9 KiB

c24elipe added the

reviewed

label 2026-05-12 11:19:48 +00:00

c22abdal added 1 commit 2026-05-12 13:32:31 +00:00

Removed warning db57acc22b

c22abdal commented 2026-05-12 13:35:49 +00:00

Author

Collaborator

Copy link

Now the warning should not appear, as well as the API calls only executing when needed and no more.

Now the warning should not appear, as well as the API calls only executing when needed and no more.

a22erigr commented 2026-05-13 06:45:08 +00:00

Collaborator

Copy link


bild.png

498 KiB

a22erigr requested review from b24idalu 2026-05-13 07:06:51 +00:00

b24idalu requested changes 2026-05-13 07:39:50 +00:00

b24idalu left a comment

Collaborator

Copy link

Review on #658

Whats done

Updated to make sure no warning will be shown and that the API is only executed when needed

Tested on Windows using Chrome & Firefox

• App starts
  • The error is still there, per picture example.
  • Checked to make sure that the api calls only happen when needed.

Inspected following files

• frontend/src/features/utility/sharedFeatures.js
  • Indentation/code styling
    • Follows prettier
  • CSS standard
    • Looks good
  • Naming convention
    • Looks good
  • Comments
    • Looks good
  • General code quality
    • Looks good other that the error still exists

What needs to be done

• frontend/src/features/utility/sharedFeatures.js
  • Fix the error in the comment aboves picture.

Conclusion

• Error needs to be fixed before merging

# Review on #658 ## Whats done Updated to make sure no warning will be shown and that the API is only executed when needed ### Tested on Windows using Chrome & Firefox + App starts + The error is still there, per picture example. + Checked to make sure that the api calls only happen when needed. ### Inspected following files + frontend/src/features/utility/sharedFeatures.js + Indentation/code styling + Follows prettier + CSS standard + Looks good + Naming convention + Looks good + Comments + Looks good + General code quality + Looks good other that the error still exists ## What needs to be done + frontend/src/features/utility/sharedFeatures.js + Fix the error in the comment aboves picture. ## Conclusion + Error needs to be fixed before merging

c22abdal commented 2026-05-13 07:47:32 +00:00

Author

Collaborator

Copy link

@a22erigr wrote in #888 (comment):

Could you please share the whole file with me because I am not getting this warning anymore

@a22erigr wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/888#issuecomment-10378: > [](/Andras/BoundlessFlowCampus2K/attachments/d81e757f-8a2c-4a55-9276-0ddc6a74e180) Could you please share the whole file with me because I am not getting this warning anymore

b24idalu was assigned by a22erigr 2026-05-13 07:51:37 +00:00

a24danwe was assigned by a22erigr 2026-05-13 07:53:38 +00:00

a22erigr commented 2026-05-13 07:54:34 +00:00

Collaborator

Copy link

@c22abdal wrote in #888 (comment):

@a22erigr wrote in #888 (comment):

Could you please share the whole file with me because I am not getting this warning anymore

Its in util and from the branche

@c22abdal wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/888#issuecomment-10465: > @a22erigr wrote in #888 (comment): > > > [](/Andras/BoundlessFlowCampus2K/attachments/d81e757f-8a2c-4a55-9276-0ddc6a74e180) > > Could you please share the whole file with me because I am not getting this warning anymore Its in util and from the branche

c22abdal commented 2026-05-13 07:58:19 +00:00

Author

Collaborator

Copy link

@a22erigr wrote in #888 (comment):

@c22abdal wrote in #888 (comment):

@a22erigr wrote in #888 (comment):

Could you please share the whole file with me because I am not getting this warning anymore

Its in util and from the branche

Yes thanks, i know that, i mean share the code because I am not getting the error. I want to check if the code is the same

@a22erigr wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/888#issuecomment-10482: > @c22abdal wrote in #888 (comment): > > > @a22erigr wrote in #888 (comment): > > > [](/Andras/BoundlessFlowCampus2K/attachments/d81e757f-8a2c-4a55-9276-0ddc6a74e180) > > > > > > Could you please share the whole file with me because I am not getting this warning anymore > > Its in util and from the branche Yes thanks, i know that, i mean share the code because I am not getting the error. I want to check if the code is the same

👍 1

a22erigr added 1 commit 2026-05-13 08:25:00 +00:00

Merge branch 'team_2_week_5' into #658-Options-dependenacy 5b02d8dbe7

a22erigr merged commit b5e6e6deaa into team_2_week_5 2026-05-13 08:25:25 +00:00

a22erigr referenced this pull request from a commit 2026-05-13 08:25:28 +00:00

Merge pull request '#658 Converted options to string' (#888) from #658-Options-dependenacy into team_2_week_5

b25marem referenced this pull request from a commit 2026-05-15 08:56:06 +00:00

Merge pull request '#658 Converted options to string' (#888) from #658-Options-dependenacy into team_2_week_5

a22erigr deleted branch #658-Options-dependenacy 2026-05-21 12:52:38 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

c24elipe

b24idalu

Labels

Clear labels   

_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  

API

  

app

  

backEnd

  

Blocked, waiting for further changes

  

bug

Something is not working

  

cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  

close

Issue to close

  

design

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

feature request

  

frontEnd

  

help wanted

Need some help

  

invalid

Something is wrong

  

low priority

  

needs input

Issue needs input from product owner or customer

  

needs review

issue is in need of review

  

project documentation

  

question

More information is needed

  

research

  

reviewed

This Issue has been reviewed

  

script

  

security

use this for security-related issues

  

SQL

  

style

  

testing

  

topLevel

Reserved for top-level, project-wide issues.

  

wontfix

This won't be fixed

No labels

_CRITICAL_

API

app

backEnd

Blocked, waiting for further changes

bug

cleanup

close

design

duplicate

enhancement

feature request

frontEnd

help wanted

invalid

low priority

needs input

needs review

project documentation

question

research

reviewed

script

security

SQL

style

testing

topLevel

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

b24idalu

a24danwe

4 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Andras/BoundlessFlowCampus2K!888

No description provided.