Andras/BoundlessFlowCampus2K

Fork 0

889-turn-off-season-themes #907

Merged

a24julot merged 1 commit from 889-turn-off-season-themes into team_1_week_5

2026-05-12 09:13:09 +00:00

b24erika commented

2026-05-12 08:41:40 +00:00

Collaborator

Broke out the function to get curr month, now imported to settings/app. Added toggle button to settings for seasonal themes, added so settings for themes are now stored in browser while refreshing.

To test if themes work you could add "--card-color-bg: pink;" to "[data-theme='spring']" in theme.css.

Broke out the function to get curr month, now imported to settings/app. Added toggle button to settings for seasonal themes, added so settings for themes are now stored in browser while refreshing. To test if themes work you could add "--card-color-bg: pink;" to "[data-theme='spring']" in theme.css.

b24erika added the

frontEnd

needs review

labels

2026-05-12 08:41:41 +00:00

b24erika self-assigned this

2026-05-12 08:41:41 +00:00

b24erika added 1 commit

2026-05-12 08:41:41 +00:00

option to remove seasonal themes e345f89461

broke out the function to get curr month, used both and now are imported to settings/app. Added toggle button to settings for seasonal themes, added so settings for themes are now stored.

b24erika referenced this pull request

2026-05-12 08:44:57 +00:00

Implement the option to turn season theme on and off #889

a24julot requested review from a24timsv

2026-05-12 08:48:25 +00:00

a24timsv approved these changes

2026-05-12 09:07:44 +00:00

a24timsv left a comment

Collaborator

The setting to toggle themes stay persistent during refreshes of the site, nice.

I also added "--card-color-bg: pink;" to "[data-theme='spring']" and when enabling the themes the color of the cards change. So it seems to be working fine.

A thing I was thinking about was if themes should be month based or date based? It would be nice if some themes were more holiday focused, such as Halloween and Midsommar. This is definitely out of scope for this PR but maybe a future issue? :)

The setting to toggle themes stay persistent during refreshes of the site, nice. I also added "--card-color-bg: pink;" to "[data-theme='spring']" and when enabling the themes the color of the cards change. So it seems to be working fine. A thing I was thinking about was if themes should be month based or date based? It would be nice if some themes were more holiday focused, such as Halloween and Midsommar. This is definitely out of scope for this PR but maybe a future issue? :)

👍 1

a24julot added

reviewed

and removed

needs review

labels

2026-05-12 09:12:52 +00:00

a24julot merged commit 06149ad68e into team_1_week_5

2026-05-12 09:13:09 +00:00

a24julot referenced this pull request from a commit

2026-05-12 09:13:12 +00:00

Merge pull request '889-turn-off-season-themes' (#907) from 889-turn-off-season-themes into team_1_week_5

b24erika commented

2026-05-12 12:25:28 +00:00

Author

Collaborator

@a24timsv wrote in #907 (comment):

The setting to toggle themes stay persistent during refreshes of the site, nice.

I also added "--card-color-bg: pink;" to "[data-theme='spring']" and when enabling the themes the color of the cards change. So it seems to be working fine.

A thing I was thinking about was if themes should be month based or date based? It would be nice if some themes were more holiday focused, such as Halloween and Midsommar. This is definitely out of scope for this PR but maybe a future issue? :)

Good addition, I approve of this additional feature! Should not be an issue to add more specific options in the function. 💯

@a24timsv wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/907#issuecomment-9891: > The setting to toggle themes stay persistent during refreshes of the site, nice. > > I also added "--card-color-bg: pink;" to "[data-theme='spring']" and when enabling the themes the color of the cards change. So it seems to be working fine. > > A thing I was thinking about was if themes should be month based or date based? It would be nice if some themes were more holiday focused, such as Halloween and Midsommar. This is definitely out of scope for this PR but maybe a future issue? :) Good addition, I approve of this additional feature! Should not be an issue to add more specific options in the function. 💯