Andras/BoundlessFlowCampus2K

Fork 0

905-enhance-color-themes-settings #923

Merged

a24julot merged 2 commits from 905-enhance-color-themes-settings into team_1_week_5

2026-05-12 14:52:36 +00:00

b24erika commented

2026-05-12 12:15:25 +00:00

Collaborator

Updated css, removed dark/light-mode since it will be a separate setting, made changes to settings css so that it wont override the css for styleselect component.

b24erika added the

frontEnd

Team 1

needs review

labels

2026-05-12 12:15:25 +00:00

b24erika self-assigned this

2026-05-12 12:15:25 +00:00

b24erika added 1 commit

2026-05-12 12:15:26 +00:00

refactored styleselect e151b8bf0d

updated css, removed dark/light-mode since it will be a separate setting, made changes to settings css so that it wont override the css for styleselect component.

b24erika referenced this pull request

2026-05-12 12:18:16 +00:00

Enhance themes in settings #905

a24julot

2026-05-12 12:42:19 +00:00

added
Under-review
and removed
needs review
labels
requested review from b24johka

b24johka commented

2026-05-12 13:11:45 +00:00

Collaborator

Review

Code standards are followed
The design looks really good! (Good job)

Question

When having the base color selected the border doesn't get focus, unlike the other colors.

No focus border:

Focus on border (Grey selected):

This is not necessarily an issue, and might be the intended design.
I was slightly confused for a split second as what was selected initially, but the text on the left side hinted.

# Review - Code standards are followed - The design looks really good! (Good job) ## Question When having the base color selected the border doesn't get focus, unlike the other colors. No focus border: ![image](/attachments/0e2fc01c-811f-45c6-aa5e-4701d774bce0) Focus on border (Grey selected): ![image](/attachments/05b457bc-5a3f-47d7-a219-efd35e187081) This is not necessarily an issue, and might be the intended design. I was slightly confused for a split second as what was selected initially, but the text on the left side hinted.

image.png

1.9 KiB

image.png

1.6 KiB

b24erika added 1 commit

2026-05-12 14:17:14 +00:00

updated theme.css 991b869e94

since there is no data-style for root, I added this selector so that the button could have it's colors. Default theme will still be the same.

b24erika commented

2026-05-12 14:19:36 +00:00

Author

Collaborator

There is now an update so that it fixes the issue that @b24johka explained, since color "root" has no selector called data-style, I implemented one with root colors just to put colors on the button.

Colors come from theme.css, which are both applied on hovering and active buttons if something look odd it is from the theme itself rather than the buttons.

Buttons right now blend in to their background since the container of the buttons gets the same color, this will be updated when themes are properly implemented.

There is now an update so that it fixes the issue that @b24johka explained, since color "root" has no selector called data-style, I implemented one with root colors just to put colors on the button. Colors come from theme.css, which are both applied on hovering and active buttons if something look odd it is from the theme itself rather than the buttons. Buttons right now blend in to their background since the container of the buttons gets the same color, this will be updated when themes are properly implemented.

bild.png

1.4 KiB

bild.png

1.6 KiB