919-dark-mode-settings #932

Merged

a24julot merged 2 commits from 919-dark-mode-settings into team_1_week_5

2026-05-13 08:03:26 +00:00

b24erika commented

2026-05-13 06:48:59 +00:00

Collaborator

Implemented dark mode toggle in settings, removed unused code and change the comments to current version of the files.

b24erika added the

frontEnd

Team 1

needs review

labels

2026-05-13 06:48:59 +00:00

b24erika self-assigned this

2026-05-13 06:48:59 +00:00

b24erika added 2 commits

2026-05-13 06:48:59 +00:00

standalone dark mode settings a10170ce0a

dark mode removed from styleselect, now added to settings

Commets, removed unused code 39cd0f9cc7

b24erika referenced this pull request

2026-05-13 06:50:22 +00:00

Break out dark/light mode #919

a24julot

2026-05-13 07:20:46 +00:00

added
Under-review
and removed
needs review
labels
requested review from a24hamrh

a24hamrh approved these changes

2026-05-13 08:00:29 +00:00

a24hamrh left a comment

Collaborator

Review on #932

Whats done

Tested on Windows 11 using Firefox

App starts
- Changed back and forth from dark mode.

Inspected following files: StyleSelect.js, Settings.js

Both
- Indentation/code styling
  - Indentation is ok
- Naming convention
  - Naming convention is followed
- Comments
  - Comments follows standards and are plenty.
- General code quality
  - The general code quality is good

Conclusion

Dark mode works, you can switch it on and off in the settings. The code looks good.

# Review on #932 ## Whats done ### Tested on Windows 11 using Firefox + App starts + Changed back and forth from dark mode. ### Inspected following files: StyleSelect.js, Settings.js + Both + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Comments + Comments follows standards and are plenty. + General code quality + The general code quality is good ## Conclusion + Dark mode works, you can switch it on and off in the settings. The code looks good.