b24erika commented

Collaborator

Calculation of left/top did not include margin set in gridbackground, emptygrid now in right place.

Issue with footer when refreshing page, emptycells extends below footer but if an card is added, it follows along. This issue seems that only I could replicate and will try it on other machines next week.

Calculation of left/top did not include margin set in gridbackground, emptygrid now in right place. Issue with footer when refreshing page, emptycells extends below footer but if an card is added, it follows along. This issue seems that only I could replicate and will try it on other machines next week.

bild.png

53 KiB

b24erika added the

frontEnd

needs review

labels

2026-05-15 10:03:34 +00:00

b24erika self-assigned this

2026-05-15 10:03:34 +00:00

b24erika added 2 commits

2026-05-15 10:03:35 +00:00

change position of empty card 4decc96caf

removed out-commented code 8a719d0184

b24erika added 1 commit

2026-05-15 12:38:20 +00:00

removed react padding b8787cd2e3

added padding to div instead, calculation was right but standard containerpadding made the empty cells missplaced

b24erika removed the

needs review

label

2026-05-15 12:39:23 +00:00

a22erigr referenced this pull request

2026-05-15 12:42:37 +00:00

Add card placeholder #945

b24erika added 1 commit

2026-05-15 12:54:29 +00:00

added css so views are not visable in footer 26f246b96f

b24erika added the

needs review

label

2026-05-15 12:58:27 +00:00

b24erika referenced this pull request

2026-05-15 12:59:23 +00:00

Add card placeholder #945

b24erika referenced this pull request

2026-05-15 13:01:02 +00:00

Add card placeholder #945

b24erika added 1 commit

2026-05-15 13:04:12 +00:00

removed import 67a5e4a254

a22erigr requested review from j21marbr

2026-05-18 12:54:13 +00:00

j21marbr commented

2026-05-18 16:03:58 +00:00

Collaborator

Review on #966

Whats done

Tested on macOS using Chrome

Tested empty grid positioning on different screen sizes
Tested refreshing behavior
Tested adding cards in edit mode
App starts
- A second scrollbar appears when the app starts in edit mode and reappears after refreshing the page until a card is added or the layout is reset
- On smaller screen sizes the footer overlaps the empty grid placeholders
- When multiple cards are added on larger screen some cards can go off screen when returning to smaller screen sizes.

Inspected following files

Dashboard.js
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Looks good
- General code quality
  - No issues found
Dashboard.module.css
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- General code quality
  - No issues found

What needs to be done

Dashboard layout behavior
- Fix the second scrollbar appearing in edit mode
- Fix the footer and empty grid placeholders overlap on smaller screen sizes
- Fix cards going off the screen on smaller screen sizes

Conclusion

The empty grid positioning has improved, however there are some responsive layout issues and the code is not ready to be merged.

# Review on #966 ## Whats done ### Tested on macOS using Chrome + Tested empty grid positioning on different screen sizes + Tested refreshing behavior + Tested adding cards in edit mode + App starts + A second scrollbar appears when the app starts in edit mode and reappears after refreshing the page until a card is added or the layout is reset + On smaller screen sizes the footer overlaps the empty grid placeholders + When multiple cards are added on larger screen some cards can go off screen when returning to smaller screen sizes. ### Inspected following files + Dashboard.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + No issues found + Dashboard.module.css + Indentation/code styling + Follows standard + Naming convention + Follows standard + General code quality + No issues found ## What needs to be done + Dashboard layout behavior + Fix the second scrollbar appearing in edit mode + Fix the footer and empty grid placeholders overlap on smaller screen sizes + Fix cards going off the screen on smaller screen sizes ## Conclusion + The empty grid positioning has improved, however there are some responsive layout issues and the code is not ready to be merged.

j21marbr commented

2026-05-18 16:04:35 +00:00

Collaborator

No description provided.

bild.png

271 KiB

bild1.png

254 KiB

j21marbr added

reviewed

and removed

needs review

labels

2026-05-18 16:06:47 +00:00

b24erika added 1 commit

2026-05-19 10:19:40 +00:00

fixed scrollbar and card outside grid 2998dcb431

There is now only one scroll bar and no views/cards can be seen outside grid while screen is smaller

b24erika added 1 commit

2026-05-19 10:42:22 +00:00

Merge branch 'team_1_week_6' into 945-change-position-empty-card 34ca0b36b3

b24erika commented

2026-05-19 10:44:06 +00:00

Author

Collaborator

@j21marbr These issues exist in the team branch and have not been caused by this issue, generally all that is change in this pull-request is the calculation of emptygrid positioning as well as removing padding.

I solved the double scrollbar problem, but the issue with partially visible views/cards is caused by cards being placed in columns outside the current resolution’s maximum column count. For example, when switching from an 8-column layout to a 4-column layout, the cards keep their original coordinates until the state updates, either by moving the cards manually or refreshing the page.

@a24julot Perhaps we should create new issues for this.

@j21marbr These issues exist in the team branch and have not been caused by this issue, generally all that is change in this pull-request is the calculation of emptygrid positioning as well as removing padding. I solved the double scrollbar problem, but the issue with partially visible views/cards is caused by cards being placed in columns outside the current resolution’s maximum column count. For example, when switching from an 8-column layout to a 4-column layout, the cards keep their original coordinates until the state updates, either by moving the cards manually or refreshing the page. @a24julot Perhaps we should create new issues for this.

bild.png

80 KiB