Fix MapView scaling on smaller card sizes #969

Merged
a22erigr merged 2 commits from 955-fix-mapview-responsiveness into team_2_week_6 2026-05-19 14:20:59 +00:00
Collaborator

Fixed MapView responsiveness issue.

Changes:

  • Improved image scaling inside smaller card sizes
  • Prevented image clipping when resizing
  • Removed unnecessary internal scrolling
  • Updated layout styling for better responsiveness
Fixed MapView responsiveness issue. Changes: * Improved image scaling inside smaller card sizes * Prevented image clipping when resizing * Removed unnecessary internal scrolling * Updated layout styling for better responsiveness
a22erigr 2026-05-18 08:27:12 +00:00
Collaborator

Review on #969

Tested on Windows using Chrome

  • App starts
    • it scales better doesn´t cut of any more, depending on size you get scrollbars

Inspected following files

  • frontend/src/features/map/MapView.js
    • Indentation/code styling

      • ok
    • CSS standard

      • In line style exist + its redundant as overflow and height already exist in the css for map-container.

          className={styles['map-container']}
          style={{
          	height: '100%',
          	overflow: 'hidden',
          }}
        
    • Naming convention

      • looks good no changes
    • Comments

      • no need as the code is readable
    • General code quality

      • ok except inline css
  • frontend/src/features/map/MapView.module.css
    • Indentation/code styling
      • ok
    • CSS standard
      • ok
    • Naming convention
      • ok
    • Comments
      • no need as the code is readable
    • General code quality
      • ok

What needs to be done

  • Remove inline css

Conclusion

  • Remove inline css before merge
# Review on #969 ### Tested on Windows using Chrome + App starts + it scales better doesn´t cut of any more, depending on size you get scrollbars ### Inspected following files + frontend/src/features/map/MapView.js + Indentation/code styling + ok + CSS standard + In line style exist + its redundant as overflow and height already exist in the css for map-container. className={styles['map-container']} style={{ height: '100%', overflow: 'hidden', }} + Naming convention + looks good no changes + Comments + no need as the code is readable + General code quality + ok except inline css + frontend/src/features/map/MapView.module.css + Indentation/code styling + ok + CSS standard + ok + Naming convention + ok + Comments + no need as the code is readable + General code quality + ok ## What needs to be done + Remove inline css ## Conclusion + Remove inline css before merge
c24danli left a comment
Collaborator

See review above

See review above
a22erigr merged commit 907e146d05 into team_2_week_6 2026-05-19 14:20:59 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!969
No description provided.