Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 144 Pull requests 13 Projects Releases Packages Wiki Activity Actions 2

#920-change-password #972

Merged
a22erigr merged 7 commits from #920-change-password into team_2_week_6 2026-05-19 19:45:37 +00:00
Conversation 6 Commits 7 Files changed 5 +116 -26
j21marbr commented 2026-05-15 11:51:23 +00:00
Collaborator
Copy link

Implemented password change functionality with old password verification.
Added:

  • Change password endpoint
  • Database query for password updates
  • Password hashing before storing new passwords
  • Validation and logging for successful and failed password change requests
Implemented password change functionality with old password verification. Added: + Change password endpoint + Database query for password updates + Password hashing before storing new passwords + Validation and logging for successful and failed password change requests
j21marbr commented 2026-05-15 11:51:42 +00:00
Author
Collaborator
Copy link
No description provided.
bild.png
378 KiB
bild.png
a22erigr 2026-05-15 13:21:36 +00:00
b23albst commented 2026-05-18 11:30:45 +00:00
Collaborator
Copy link

I just wanted to bring attention to the change that was made to AuthResponse in pr #973. It now expects an access token and error type. Access token can just be set to null and when there is an error, an appropriate error type should be used.

I just wanted to bring attention to the change that was made to AuthResponse in pr #973. It now expects an access token and error type. Access token can just be set to null and when there is an error, an appropriate error type should be used.
👍 2
b25marem commented 2026-05-18 15:45:18 +00:00
Collaborator
Copy link

Review on #920

Whats done

Password change functionality has been implemented.

Tested on Windows using PowerShell

  • Tested signup.
  • Tested login.
  • Tested password change.
  • Tested that old password no longer works after password change.
  • Tested that login with the new password works.
  • App starts with postgres and loginService.

Inspected following files

  • DatabaseLogic/DatabaseQueries.cs

    • Indentation/code styling: OK.
    • Naming convention: OK.
    • Comments: XML comments are added for UpdatePassword.
    • General code quality: UpdatePassword is clear and works as expected.

  • DatabaseLogic/IDatabaseQueries.cs

    • Indentation/code styling: Problem noted. UpdatePassword has extra indentation.
    • Naming convention: OK.
    • General code quality: OK.

  • Endpoints/AuthEndpoints.cs

    • Indentation/code styling: Mostly OK.
    • Naming convention: Existing auth routes use mixed casing (/auth/login, /auth/SignUp, /auth/changepassword). Consider standardizing route naming for consistency.
    • Comments: Uses multi-line comments where single-line comments or XML comments would better match the standard.
    • General code quality: Endpoint works as expected.

  • Models/Requests/ChangePasswordDto.cs

    • Indentation/code styling: OK.
    • Naming convention: OK.

  • Services/AuthService.cs

    • Indentation/code styling: Extra blank lines before ChangePasswordAsync.
    • Naming convention: OK.

What needs to be done

  • IDatabaseQueries.cs

  • Fix indentation for UpdatePassword.

  • AuthEndpoints.cs

  • Consider standardizing auth route casing.

  • AuthService.cs

  • Remove extra blank lines.

Conclusion

  • The password change functionality works as intended in local testing.
  • Only minor code standard and cleanup issues were found.
  • Ready after small cleanup fixes.
# Review on #920 ## Whats done Password change functionality has been implemented. ### Tested on Windows using PowerShell * Tested signup. * Tested login. * Tested password change. * Tested that old password no longer works after password change. * Tested that login with the new password works. * App starts with `postgres` and `loginService`. ### Inspected following files * `DatabaseLogic/DatabaseQueries.cs` * Indentation/code styling: OK. * Naming convention: OK. * Comments: XML comments are added for `UpdatePassword`. * General code quality: `UpdatePassword` is clear and works as expected. * `DatabaseLogic/IDatabaseQueries.cs` * Indentation/code styling: Problem noted. `UpdatePassword` has extra indentation. * Naming convention: OK. * General code quality: OK. * `Endpoints/AuthEndpoints.cs` * Indentation/code styling: Mostly OK. * Naming convention: Existing auth routes use mixed casing (`/auth/login`, `/auth/SignUp`, `/auth/changepassword`). Consider standardizing route naming for consistency. * Comments: Uses multi-line comments where single-line comments or XML comments would better match the standard. * General code quality: Endpoint works as expected. * `Models/Requests/ChangePasswordDto.cs` * Indentation/code styling: OK. * Naming convention: OK. * `Services/AuthService.cs` * Indentation/code styling: Extra blank lines before `ChangePasswordAsync`. * Naming convention: OK. ## What needs to be done * `IDatabaseQueries.cs` * Fix indentation for `UpdatePassword`. * `AuthEndpoints.cs` * Consider standardizing auth route casing. * `AuthService.cs` * Remove extra blank lines. ## Conclusion * The password change functionality works as intended in local testing. * Only minor code standard and cleanup issues were found. * Ready after small cleanup fixes.
b25marem commented 2026-05-18 15:54:47 +00:00
Collaborator
Copy link

Regarding the comment above about PR #973: I could not see the new AuthResponse changes being used yet. The implementation still seems to use the old constructors.

Regarding the comment above about PR #973: I could not see the new `AuthResponse` changes being used yet. The implementation still seems to use the old constructors.
b25marem commented 2026-05-19 06:11:19 +00:00
Collaborator
Copy link

Review after latest changes:

Fixed:

  • IDatabaseQueries.cs: indentation for UpdatePassword is now fixed.
  • AuthEndpoints.cs: some multi-line comments were replaced with // comments.
  • AuthService.cs: several error responses now follow the updated AuthResponse format from PR #973 by using accessToken = null together with ErrorTypes.

Remaining issues:

  • IDatabaseQueries.cs

    • Typo still exists in the comment:
      succefull → successful.

  • AuthEndpoints.cs

    • Route naming is still inconsistent:
      /login, /SignUp, /ChangePassword
      use mixed casing conventions. It would be good to standardize endpoint naming for consistency.
    • A multi-line comment still exists above /ChangePassword.

  • ChangePasswordDto.cs

    • Typo still exists in the comment:
      tranfer to transfer.
    • The DTO still lacks validation attributes such as [Required].

  • AuthService.cs

    • ChangePasswordAsync still does not null-check changePasswordDto before accessing its properties.
    • There is still an extra blank line directly after try.
    • The success/fallback response still uses the old constructor style:
      return new AuthResponse(result ? null : "Failed to update password");
      This should also follow the new AuthResponse structure introduced in PR #973.
    • The catch block still returns raw exception.Message to the client:
      return new AuthResponse(null, exception.Message, ErrorTypes.Internal);
      It would be safer to log the internal exception and return a generic error message instead.
    • XML comment typo:
      A AuthResponse object → An AuthResponse object.
Review after latest changes: Fixed: * IDatabaseQueries.cs: indentation for UpdatePassword is now fixed. * AuthEndpoints.cs: some multi-line comments were replaced with // comments. * AuthService.cs: several error responses now follow the updated AuthResponse format from PR #973 by using accessToken = null together with ErrorTypes. Remaining issues: * IDatabaseQueries.cs * Typo still exists in the comment: succefull → successful. * AuthEndpoints.cs * Route naming is still inconsistent: /login, /SignUp, /ChangePassword use mixed casing conventions. It would be good to standardize endpoint naming for consistency. * A multi-line comment still exists above /ChangePassword. * ChangePasswordDto.cs * Typo still exists in the comment: tranfer to transfer. * The DTO still lacks validation attributes such as [Required]. * AuthService.cs * ChangePasswordAsync still does not null-check changePasswordDto before accessing its properties. * There is still an extra blank line directly after try. * The success/fallback response still uses the old constructor style: return new AuthResponse(result ? null : "Failed to update password"); This should also follow the new AuthResponse structure introduced in PR #973. * The catch block still returns raw exception.Message to the client: return new AuthResponse(null, exception.Message, ErrorTypes.Internal); It would be safer to log the internal exception and return a generic error message instead. * XML comment typo: A AuthResponse object → An AuthResponse object.
b25marem commented 2026-05-19 14:56:48 +00:00
Collaborator
Copy link

looks good. ready to merge

looks good. ready to merge
👍 1
a22erigr merged commit e0e40af640 into team_2_week_6 2026-05-19 19:45:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b25marem
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!972
No description provided.