Improved UnixRebuildScriptDebug #981

Merged

a22erigr merged 2 commits from UnixRebuildDebug.sh into team_2_week_6

2026-05-18 12:11:55 +00:00

a22erigr commented

2026-05-17 15:04:28 +00:00

Collaborator

The script now before running copies everything from the main Unix
script. To make sure the script does not run in parallel TR is used to
replace all & with empty space.

The script now before running copies everything from the main Unix script. To make sure the script does not run in parallel TR is used to replace all & with empty space.

a22erigr added the

needs review

label

2026-05-17 15:04:28 +00:00

a22erigr added 1 commit

2026-05-17 15:04:28 +00:00

Improved UnixRebuildScriptDebug d5881492c3

The script now before running copies everything from the main Unix
script. To make sure the script does not run in parallel TR is used to
replace all & with empty space.

a22erigr added 1 commit

2026-05-17 20:14:05 +00:00

Updated script 3adc8caf69

updated script. The second part now only used sed. The input is no
longer piped to TR. Everything is done in the sed part

§

a22erigr requested review from b23albst

2026-05-18 09:10:47 +00:00

b23albst requested changes

2026-05-18 12:09:04 +00:00

b23albst left a comment

Collaborator

Review on #981

Whats done

Tested UnixRebuildDebug on a fresh clone of the repo to make sure that all images were build and that docker could compose up afterwards

Tested on ubuntu

RebuildDebug script works and after it was run, docker compose up worked
App starts
- All views worked like normal

Inspected following files

scripts/UnixRebuildDebug.sh
- Indentation/code styling ok
- Naming convention ok
- Comments ok

What needs to be done

This is sort of unrelated to the issue at hand, but when running docker compose up, it complained that there were tabs in the compose file at lines 271 and 278. It was fixed by prettier by simply saving the file, but I thought it was still worth bringing attention to

Conclusion

I think this can be merged, but the tabs in the compose file should be removed first

# Review on #981 ## Whats done Tested UnixRebuildDebug on a fresh clone of the repo to make sure that all images were build and that docker could compose up afterwards ### Tested on ubuntu + RebuildDebug script works and after it was run, docker compose up worked + App starts + All views worked like normal ### Inspected following files + scripts/UnixRebuildDebug.sh + Indentation/code styling ok + Naming convention ok + Comments ok ## What needs to be done + This is sort of unrelated to the issue at hand, but when running docker compose up, it complained that there were tabs in the compose file at lines 271 and 278. It was fixed by prettier by simply saving the file, but I thought it was still worth bringing attention to ## Conclusion + I think this can be merged, but the tabs in the compose file should be removed first

a22erigr merged commit efd1387cc3 into team_2_week_6

2026-05-18 12:11:55 +00:00

a22erigr referenced this pull request from a commit

2026-05-18 12:11:57 +00:00

Merge pull request 'Improved UnixRebuildScriptDebug' (#981) from UnixRebuildDebug.sh into team_2_week_6

a22erigr deleted branch UnixRebuildDebug.sh

2026-05-21 12:40:26 +00:00