Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

982-enhance-toggle-toolbar #986

Merged
a24julot merged 2 commits from 982-enhance-toggle-toolbar into team_1_week_6 2026-05-19 10:15:03 +00:00
Conversation 3 Commits 2 Files changed 4 +13 -12
b24erika commented 2026-05-18 08:08:04 +00:00
Collaborator
Copy link

What has changed:

Color for text now follows themes, changed content of button, added a border to button and removed margin for dashboard causing the text to not be aligned with the text below.

## What has changed: Color for text now follows themes, changed content of button, added a border to button and removed margin for dashboard causing the text to not be aligned with the text below.
now the text displayed in toggle-button has the theme color for text, added a border aswell.
a24timsv requested changes 2026-05-18 11:30:32 +00:00
Dismissed
a24timsv left a comment
Collaborator
Copy link

The toggle button is more clear now, just some small things:

  • Is the button too big? On big screens it might be okay but on phones it looks too big.
  • The text should be used with localization (see specific comment).
The toggle button is more clear now, just some small things: - Is the button too big? On big screens it might be okay but on phones it looks too big. - The text should be used with localization (see specific comment).
image.png
48 KiB
image.png
79 KiB
image.png image.png
frontend/src/pages/dashboard/Dashboard.js Outdated
@ -347,3 +347,3 @@
}}
>
{showIcon ? '▴' : '▾'}
{showIcon ? '── HIDE TOOLBAR ──' : '── SHOW TOOLBAR ──'}
a24timsv commented 2026-05-18 11:27:03 +00:00
Collaborator
Copy link

This should use localization.

This should use localization.
b24erika commented 2026-05-18 11:55:23 +00:00
Author
Collaborator
Copy link

Localization is now added, button is big after customer feedback since it might be hard to press a small one, might yet again ask the customer.

Localization is now added, button is big after customer feedback since it might be hard to press a small one, might yet again ask the customer.
bild.png
23 KiB
bild.png
a24timsv approved these changes 2026-05-18 12:37:30 +00:00
a24timsv left a comment
Collaborator
Copy link

Looks good! Everything I commented on and could think of has been covered.

Looks good! Everything I commented on and could think of has been covered.
a24julot merged commit a40cc148b1 into team_1_week_6 2026-05-19 10:15:03 +00:00
c24danli deleted branch 982-enhance-toggle-toolbar 2026-05-22 12:16:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24timsv
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b24erika
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!986
No description provided.