Better "?" and "X" for the cards #1032

Open
opened 2026-05-20 10:55:50 +00:00 by a24julot · 18 comments
Collaborator

The "?" and "X" needs better placement and design
image

Originally posted by @c24danli in #1020 (comment)

The "?" and "X" needs better placement and design ![image](/attachments/cd477c85-9782-4166-a16c-d5f69fea6c74) _Originally posted by @c24danli in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/1020#issuecomment-12046_
Collaborator

Thoughts on this? @a24julot

image
image

Thoughts on this? @a24julot ![image](/attachments/b1d6b2c2-c48c-4957-887d-29c5074a2666) ![image](/attachments/b63ba126-061b-470a-8b62-9d2364146dd2)
Collaborator

I think that the placement/size might feel a bit off due to the small size of the header, but I think that it works

I think that the placement/size might feel a bit off due to the small size of the header, but I think that it works
Author
Collaborator

The original thought was to follow the design in issue #961, so that it is more attractive buttons rather than just an "X". This is not an urgent issue. @a24vinla

The original thought was to follow the design in issue https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/961, so that it is more attractive buttons rather than just an "X". This is not an urgent issue. @a24vinla
Collaborator

What happened to the one I made 😭

What happened to the one I made 😭
Author
Collaborator

It somehow got lost in the merge, but maybe it can be implemented again, it was fixed in PR #999 by @b24hugst

It somehow got lost in the merge, but maybe it can be implemented again, it was fixed in PR https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/999 by @b24hugst
Collaborator

It's still in the dashboard.css but not used in the javascript file:

image

It's still in the dashboard.css but not used in the javascript file: ![image](/attachments/7a69a191-f226-43e6-afe7-31a899d496e1)
Author
Collaborator
@a24vinla
Collaborator

Thoughts on new design @a24julot ?

New design with border:
image
image
Without border:
image
image

Thoughts on new design @a24julot ? New design with border: ![image](/attachments/831312ed-c312-4b03-8ac8-44d8571dbd6f) ![image](/attachments/a2f2340b-b97d-4cf8-a842-b082b73c1aea) Without border: ![image](/attachments/b715bb8b-853f-4b2f-922f-5094585b7113) ![image](/attachments/c59b494b-0024-4b86-9120-c8638f245311)
Collaborator

These use material design icons

These use material design icons
Author
Collaborator

They look great, but have you checked the colors accessibility, it is kind of hard to see, maybe it would be better i the x is white? @a22erigr do you have any thoughts?

They look great, but have you checked the colors accessibility, it is kind of hard to see, maybe it would be better i the x is white? @a22erigr do you have any thoughts?
Collaborator

This follows our current light/dark colour scheme, and I think an overhaul of that would be much better than hardcoding individual components. The current colour scheme has a lot of issues pertain to light/dark mode.

This follows our current light/dark colour scheme, and I think an overhaul of that would be much better than hardcoding individual components. The current colour scheme has a lot of issues pertain to light/dark mode.
Author
Collaborator

Yes, we are working on that, im just not sure what the best approach is for the x button, but it should algin with the other colors on the card, so a white x may be the way to go, but wait for input from other leaders, @a22erigr @c24danli @a24sakma

Yes, we are working on that, im just not sure what the best approach is for the x button, but it should algin with the other colors on the card, so a white x may be the way to go, but wait for input from other leaders, @a22erigr @c24danli @a24sakma
Collaborator

@a24julot wrote in #1032 (comment):

Yes, we are working on that, im just not sure what the best approach is for the x button, but it should algin with the other colors on the card, so a white x may be the way to go, but wait for input from other leaders, @a22erigr @c24danli @a24sakma

I agree that a better approach is to have the X colored white. In my opinion it worked out grate when we implemented this in settings page bild

@a24julot wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/1032#issuecomment-12535: > Yes, we are working on that, im just not sure what the best approach is for the x button, but it should algin with the other colors on the card, so a white x may be the way to go, but wait for input from other leaders, @a22erigr @c24danli @a24sakma I agree that a better approach is to have the X colored white. In my opinion it worked out grate when we implemented this in settings page ![bild](/attachments/d4b903a2-1af2-47dc-adbd-38e934ee2bdb)
1.8 KiB
Collaborator

bild
bild

![bild](/attachments/a786de59-f4c5-4881-b827-707d6679cbda) ![bild](/attachments/4a22dc6e-4ee3-4e43-8e32-4470a1e9c1ad)
Collaborator

image
Looks better!

![image](/attachments/52567ad7-f890-467d-8a37-7b1887390e0d) Looks better!
Collaborator

Agree as in the settings page the white text at least works better then black, we might have to think it through on some of the lighter themes later, but i would go with white now

Agree as in the settings page the white text at least works better then black, we might have to think it through on some of the lighter themes later, but i would go with white now
Collaborator

Comparison of the two with another theme, where the black looks better in my opinion
image

Comparison of the two with another theme, where the black looks better in my opinion ![image](/attachments/19754df0-8dfb-4f2a-be1f-883189a84692)
Collaborator

Yes it gets slightly worse at the light themes, but the dark text on dark themes looks worse then light text on light themes.

Yes it gets slightly worse at the light themes, but the dark text on dark themes looks worse then light text on light themes.
Sign in to join this conversation.
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K#1032
No description provided.