Better "?" and "X" for the cards #1032
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K#1032
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The "?" and "X" needs better placement and design
Originally posted by @c24danli in #1020 (comment)
Thoughts on this? @a24julot
I think that the placement/size might feel a bit off due to the small size of the header, but I think that it works
The original thought was to follow the design in issue #961, so that it is more attractive buttons rather than just an "X". This is not an urgent issue. @a24vinla
What happened to the one I made 😭
It somehow got lost in the merge, but maybe it can be implemented again, it was fixed in PR #999 by @b24hugst
It's still in the dashboard.css but not used in the javascript file:
@a24vinla
Thoughts on new design @a24julot ?
New design with border:
Without border:
These use material design icons
They look great, but have you checked the colors accessibility, it is kind of hard to see, maybe it would be better i the x is white? @a22erigr do you have any thoughts?
This follows our current light/dark colour scheme, and I think an overhaul of that would be much better than hardcoding individual components. The current colour scheme has a lot of issues pertain to light/dark mode.
Yes, we are working on that, im just not sure what the best approach is for the x button, but it should algin with the other colors on the card, so a white x may be the way to go, but wait for input from other leaders, @a22erigr @c24danli @a24sakma
@a24julot wrote in #1032 (comment):
I agree that a better approach is to have the X colored white. In my opinion it worked out grate when we implemented this in settings page
Looks better!
Agree as in the settings page the white text at least works better then black, we might have to think it through on some of the lighter themes later, but i would go with white now
Comparison of the two with another theme, where the black looks better in my opinion
Yes it gets slightly worse at the light themes, but the dark text on dark themes looks worse then light text on light themes.
Has been merged in #1081