1032-Better-and-X-for-the-cards #1081

Merged

a22erigr merged 4 commits from 1032-Better-and-X-for-the-cards into team_2_week_7

2026-05-21 14:36:18 +00:00

a24vinla commented

2026-05-21 12:30:46 +00:00

Collaborator

What has been done

Changed card handle bar icons to svg's

frontend/src/assets/materialdesign
- Moved all material design icons from settings folder to assets folder
- Added close, close with border and question mark icon
frontend/src/components/Tooltip/Tooltip.js
- Removed ? as text and added ? as vsg instead
- Also added div container for icon
frontend/src/components/Tooltip/Tooltip.module.css
- Added styling for icon
frontend/src/pages/dashboard/Dashboard.js
- Removed ? as text and added ? as vsg instead
- Also added div container for icon
frontend/src/pages/dashboard/Dashboard.module.css
- Added styling for icon
frontend/src/pages/settings/Settings.js
- Changed path for import of icons

Thoughts

We might have to change which colour the svg's take when/if we change style colours

## What has been done Changed card handle bar icons to svg's + frontend/src/assets/materialdesign + Moved all material design icons from settings folder to assets folder + Added close, close with border and question mark icon + frontend/src/components/Tooltip/Tooltip.js + Removed ? as text and added ? as vsg instead + Also added div container for icon + frontend/src/components/Tooltip/Tooltip.module.css + Added styling for icon + frontend/src/pages/dashboard/Dashboard.js + Removed ? as text and added ? as vsg instead + Also added div container for icon + frontend/src/pages/dashboard/Dashboard.module.css + Added styling for icon + frontend/src/pages/settings/Settings.js + Changed path for import of icons ## Thoughts We might have to change which colour the svg's take when/if we change style colours

a24vinla added the

needs review

label

2026-05-21 12:30:46 +00:00

a24vinla added 4 commits

2026-05-21 12:30:46 +00:00

Moved existing materialdesign svg's to assets c6320d703c

Added new material design icons 0cfaf9fd45

Added close icon to card + styling 707c9dd122

Added question mark icon to tooltip component + styling 5308c7b010

a22erigr requested review from a24danwe

2026-05-21 13:01:16 +00:00

a24danwe commented

2026-05-21 14:05:30 +00:00

Collaborator

Review on #1081

Whats done

Tested on macOS using Chrome

App starts correctly
Dashboard renders correctly
Tooltip icon displays correctly
Remove card icon displays correctly
Tooltip question mark text still works

Inspected following files

frontend/src/components/Tooltip/Tooltip.js
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Follows standard
- General code quality
  - Good
frontend/src/components/Tooltip/Tooltip.module.css
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Follows standard
- General code quality
  - Good
frontend/src/pages/dashboard/Dashboard.js
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Follows standard
- General code quality
  - Good
frontend/src/pages/dashboard/Dashboard.module.css
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Follows standard
- General code quality
  - Good

What needs to be done

Nothing

Conclusion

Everything looks correct. This can be merged.

# Review on #1081 ## Whats done ### Tested on macOS using Chrome + App starts correctly + Dashboard renders correctly + Tooltip icon displays correctly + Remove card icon displays correctly + Tooltip question mark text still works ### Inspected following files + frontend/src/components/Tooltip/Tooltip.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Follows standard + General code quality + Good + frontend/src/components/Tooltip/Tooltip.module.css + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Follows standard + General code quality + Good + frontend/src/pages/dashboard/Dashboard.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Follows standard + General code quality + Good + frontend/src/pages/dashboard/Dashboard.module.css + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Follows standard + General code quality + Good ## What needs to be done + Nothing ## Conclusion Everything looks correct. This can be merged.