a24hamrh commented

Collaborator

Made a new file to handle the functionality of adding new cards. This functionality is now handeld in useAddNewView.js

a24hamrh added 1 commit

2026-04-24 14:00:01 +00:00

#531-break-out-add-new-card-functionality 8070709ed2

Made a new file to handle the functionality of adding new cards. This functionality is now handeld in useAddNewView.js

a24hamrh added the

needs review

label

2026-04-24 14:00:13 +00:00

a24hamrh referenced this pull request

2026-04-24 14:01:00 +00:00

Break out add new card functionality from dashboard.js #531

b24johka requested review from b24erika

2026-04-27 07:03:04 +00:00

b24johka commented

2026-04-27 07:04:39 +00:00

Collaborator

Did the functionality work? we are under the impression that the parameters are wrong. see #568

Did the functionality work? we are under the impression that the parameters are wrong. see https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/568

b24erika commented

2026-04-27 07:54:13 +00:00

Collaborator

Review on #558

Whats done

Reviewed code and tested so that everything still works in frontend.

Tested on Windows using Firefox

Focus on checking the add view feature as well as remove/resize and the overall interaction.
App starts
- Adding views works.
- Remove views works.
- Resize works.
- View cache works.

Inspected following files "useAddNewView.js" and "Dashboard.js".

useAddNewView.js
- Indentation/code styling
  - Indentation is ok, prettier is followed.
- Naming convention
  - This file should be an component which result in new naming of file.
- Comments
  - Could be good to have a function comment so other developers in the future do not need to guess what functionality it returns.
- General code quality
  - Good.
Dashboard.js
- Indentation/code styling
  - Indentation is ok, prettier is followed.
- General code quality
  - Good.

What needs to be done

useAddNewView.js
- Move to the component folder and rename the file.
- Add comment to (export) function.

Conclusion

No need to change code, it works as intended but comment off function and move of file should be done. The pull-request has merge-conflicts and could be solved, if not contact issue-coordinator.
There is also an issue that the view config dont work, the issue lies in the addNewView function with wrong parameters to the config and should look like the picture, viewType should be removed and only view passed. This issue is not related to the issue itself but it is a small fix.

# Review on #558 ## Whats done Reviewed code and tested so that everything still works in frontend. ### Tested on Windows using Firefox + Focus on checking the add view feature as well as remove/resize and the overall interaction. + App starts + Adding views works. + Remove views works. + Resize works. + View cache works. ### Inspected following files "useAddNewView.js" and "Dashboard.js". + useAddNewView.js + Indentation/code styling + Indentation is ok, prettier is followed. + Naming convention + This file should be an component which result in new naming of file. + Comments + Could be good to have a function comment so other developers in the future do not need to guess what functionality it returns. + General code quality + Good. + Dashboard.js + Indentation/code styling + Indentation is ok, prettier is followed. + General code quality + Good. ## What needs to be done + useAddNewView.js + Move to the component folder and rename the file. + Add comment to (export) function. ## Conclusion + No need to change code, it works as intended but comment off function and move of file should be done. The pull-request has merge-conflicts and could be solved, if not contact issue-coordinator. + There is also an issue that the view config dont work, the issue lies in the addNewView function with wrong parameters to the config and should look like the picture, viewType should be removed and only view passed. This issue is not related to the issue itself but it is a small fix.

bild.png

6.1 KiB

b24erika added

frontEnd

and removed

needs review

labels

2026-04-27 07:58:00 +00:00

b24johka commented

2026-04-27 09:02:20 +00:00

Collaborator

We are concerned about the strucute of the project regarding all of the dashboard, components are supposed to consist of reusable front end components.. But has turned into more like a dashboard subdirectory.

b24johka commented

2026-04-28 08:48:36 +00:00

Collaborator

The requested changes in this PR will be taking place after the restructuring of dashboard into a separate folder.
The review has been sufficient and this will be merged.

The requested changes in this PR will be taking place after the restructuring of dashboard into a separate folder. The review has been sufficient and this will be merged.

b24johka commented

2026-04-28 09:00:39 +00:00

Collaborator

This has been merged now.

b24johka closed this pull request

2026-04-28 09:01:46 +00:00