Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 142 Pull requests 15 Projects Releases Packages Wiki Activity Actions 2

#531-break-out-add-new-card-functionality #558

Closed
a24hamrh wants to merge 0 commits from 531-break-out-new-card-functionality into team_1_week_3
pull from: 531-break-out-new-card-functionality
merge into: Andras:team_1_week_3
Conversation 5 Commits - Files changed -
a24hamrh commented 2026-04-24 14:00:00 +00:00
Collaborator
Copy link

Made a new file to handle the functionality of adding new cards. This functionality is now handeld in useAddNewView.js

Made a new file to handle the functionality of adding new cards. This functionality is now handeld in useAddNewView.js
Made a new file to handle the functionality of adding new cards. This functionality is now handeld in useAddNewView.js
b24johka 2026-04-27 07:01:31 +00:00
b24johka commented 2026-04-27 07:04:39 +00:00
Collaborator
Copy link

Did the functionality work? we are under the impression that the parameters are wrong. see #568

Did the functionality work? we are under the impression that the parameters are wrong. see https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/568
b24erika commented 2026-04-27 07:54:13 +00:00
Collaborator
Copy link

Review on #558

Whats done

Reviewed code and tested so that everything still works in frontend.

Tested on Windows using Firefox

  • Focus on checking the add view feature as well as remove/resize and the overall interaction.
  • App starts
    • Adding views works.
    • Remove views works.
    • Resize works.
    • View cache works.

Inspected following files "useAddNewView.js" and "Dashboard.js".

  • useAddNewView.js
    • Indentation/code styling
      • Indentation is ok, prettier is followed.
    • Naming convention
      • This file should be an component which result in new naming of file.
    • Comments
      • Could be good to have a function comment so other developers in the future do not need to guess what functionality it returns.
    • General code quality
      • Good.
  • Dashboard.js
    • Indentation/code styling
      • Indentation is ok, prettier is followed.
    • General code quality
      • Good.

What needs to be done

  • useAddNewView.js
    • Move to the component folder and rename the file.
    • Add comment to (export) function.

Conclusion

  • No need to change code, it works as intended but comment off function and move of file should be done. The pull-request has merge-conflicts and could be solved, if not contact issue-coordinator.
  • There is also an issue that the view config dont work, the issue lies in the addNewView function with wrong parameters to the config and should look like the picture, viewType should be removed and only view passed. This issue is not related to the issue itself but it is a small fix.
# Review on #558 ## Whats done Reviewed code and tested so that everything still works in frontend. ### Tested on Windows using Firefox + Focus on checking the add view feature as well as remove/resize and the overall interaction. + App starts + Adding views works. + Remove views works. + Resize works. + View cache works. ### Inspected following files "useAddNewView.js" and "Dashboard.js". + useAddNewView.js + Indentation/code styling + Indentation is ok, prettier is followed. + Naming convention + This file should be an component which result in new naming of file. + Comments + Could be good to have a function comment so other developers in the future do not need to guess what functionality it returns. + General code quality + Good. + Dashboard.js + Indentation/code styling + Indentation is ok, prettier is followed. + General code quality + Good. ## What needs to be done + useAddNewView.js + Move to the component folder and rename the file. + Add comment to (export) function. ## Conclusion + No need to change code, it works as intended but comment off function and move of file should be done. The pull-request has merge-conflicts and could be solved, if not contact issue-coordinator. + There is also an issue that the view config dont work, the issue lies in the addNewView function with wrong parameters to the config and should look like the picture, viewType should be removed and only view passed. This issue is not related to the issue itself but it is a small fix.
bild.png
6.1 KiB
bild.png
b24johka commented 2026-04-27 09:02:20 +00:00
Collaborator
Copy link

We are concerned about the strucute of the project regarding all of the dashboard, components are supposed to consist of reusable front end components.. But has turned into more like a dashboard subdirectory.

We are concerned about the strucute of the project regarding all of the dashboard, components are supposed to consist of reusable front end components.. But has turned into more like a dashboard subdirectory.
b24johka commented 2026-04-28 08:48:36 +00:00
Collaborator
Copy link

The requested changes in this PR will be taking place after the restructuring of dashboard into a separate folder.
The review has been sufficient and this will be merged.

The requested changes in this PR will be taking place after the restructuring of dashboard into a separate folder. The review has been sufficient and this will be merged.
b24johka commented 2026-04-28 09:00:39 +00:00
Collaborator
Copy link

This has been merged now.

This has been merged now.
b24johka closed this pull request 2026-04-28 09:01:46 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
b24erika
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!558
No description provided.