#553-improve-style-selector #629

Closed
j21marbr wants to merge 0 commits from #553-improve-style-selector into team_2_week_3
Collaborator

Changes:

  • Replaced table layout with css grid
  • Updated style buttons to use map
  • Added hover preview to show theme before selecting
  • Added active state to show the currently selected style
  • Updated toggle switch to include light and dark mode icons
Changes: - Replaced table layout with css grid - Updated style buttons to use map - Added hover preview to show theme before selecting - Added active state to show the currently selected style - Updated toggle switch to include light and dark mode icons
Author
Collaborator
No description provided.
Author
Collaborator
No description provided.
a24noabe approved these changes 2026-04-28 21:27:26 +00:00
a24noabe left a comment
Collaborator

Review on #629

Whats done

Checked all files changed for coding standards, website functionality & UI appearance

Tested on Windows 11 using Google Chrome

  • Style selector looks good, better than the one on the team branch (images further down)
  • App starts
    • Some errors from APIs but they also exist on the team branch, so i disregard them as there are only changes to the frontend, and not to any API calls.
    • Tested all themes in both light and dark mode. They all work.

Inspected following files

  • All changed files

What needs to be done

  • Clarify if svg files are ok to use, if made by dev, it's ok. If not made by dev, comment in #629 a link to the source showing the files are ok to use in this project. (Licensing)

Conclusion

  • This is ready to be merged once the svg files are confirmed to be ok
# Review on #629 ## Whats done Checked all files changed for coding standards, website functionality & UI appearance ### Tested on Windows 11 using Google Chrome + Style selector looks good, better than the one on the team branch (images further down) + App starts + Some errors from APIs but they also exist on the team branch, so i disregard them as there are only changes to the frontend, and not to any API calls. + Tested all themes in both light and dark mode. They all work. ### Inspected following files + All changed files ## What needs to be done + Clarify if svg files are ok to use, if made by dev, it's ok. If not made by dev, comment in #629 a link to the source showing the files are ok to use in this project. (Licensing) ## Conclusion + This is ready to be merged once the svg files are confirmed to be ok
Collaborator

Pics

Before:
image
After:
image
I changed the theme between, but I think it looks a lot better

## Pics Before: ![image](/attachments/a4b060fd-c582-4829-bd8d-2f6c8d89d555) After: ![image](/attachments/da5b33d9-6078-4c3c-8189-bad8ef2c6552) I changed the theme between, but I think it looks a lot better
Collaborator

Good job everyone! Will merge manually

Good job everyone! Will merge manually
a24vinla closed this pull request 2026-04-29 07:20:30 +00:00
a22erigr deleted branch #553-improve-style-selector 2026-05-11 18:20:48 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!629
No description provided.