Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#553-improve-style-selector #629

Closed
j21marbr wants to merge 0 commits from #553-improve-style-selector into team_2_week_3
pull from: #553-improve-style-selector
merge into: Andras:team_2_week_3
Conversation 5 Commits - Files changed - +75 -63
j21marbr commented 2026-04-28 13:34:13 +00:00
Collaborator
Copy link

Changes:

  • Replaced table layout with css grid
  • Updated style buttons to use map
  • Added hover preview to show theme before selecting
  • Added active state to show the currently selected style
  • Updated toggle switch to include light and dark mode icons
Changes: - Replaced table layout with css grid - Updated style buttons to use map - Added hover preview to show theme before selecting - Added active state to show the currently selected style - Updated toggle switch to include light and dark mode icons
j21marbr commented 2026-04-28 13:37:15 +00:00
Author
Collaborator
Copy link
No description provided.
img.png
60 KiB
img.png
j21marbr commented 2026-04-28 13:39:58 +00:00
Author
Collaborator
Copy link
No description provided.
img_.png
70 KiB
img_.png
a24noabe approved these changes 2026-04-28 21:27:26 +00:00
a24noabe left a comment
Collaborator
Copy link

Review on #629

Whats done

Checked all files changed for coding standards, website functionality & UI appearance

Tested on Windows 11 using Google Chrome

  • Style selector looks good, better than the one on the team branch (images further down)
  • App starts
    • Some errors from APIs but they also exist on the team branch, so i disregard them as there are only changes to the frontend, and not to any API calls.
    • Tested all themes in both light and dark mode. They all work.

Inspected following files

  • All changed files

What needs to be done

  • Clarify if svg files are ok to use, if made by dev, it's ok. If not made by dev, comment in #629 a link to the source showing the files are ok to use in this project. (Licensing)

Conclusion

  • This is ready to be merged once the svg files are confirmed to be ok
# Review on #629 ## Whats done Checked all files changed for coding standards, website functionality & UI appearance ### Tested on Windows 11 using Google Chrome + Style selector looks good, better than the one on the team branch (images further down) + App starts + Some errors from APIs but they also exist on the team branch, so i disregard them as there are only changes to the frontend, and not to any API calls. + Tested all themes in both light and dark mode. They all work. ### Inspected following files + All changed files ## What needs to be done + Clarify if svg files are ok to use, if made by dev, it's ok. If not made by dev, comment in #629 a link to the source showing the files are ok to use in this project. (Licensing) ## Conclusion + This is ready to be merged once the svg files are confirmed to be ok
a24noabe commented 2026-04-28 21:32:58 +00:00
Collaborator
Copy link

Pics

Before:
image
After:
image
I changed the theme between, but I think it looks a lot better

## Pics Before: ![image](/attachments/a4b060fd-c582-4829-bd8d-2f6c8d89d555) After: ![image](/attachments/da5b33d9-6078-4c3c-8189-bad8ef2c6552) I changed the theme between, but I think it looks a lot better
image.png
9.7 KiB
image.png
11 KiB
a24vinla commented 2026-04-29 07:20:25 +00:00
Collaborator
Copy link

Good job everyone! Will merge manually

Good job everyone! Will merge manually
a24vinla closed this pull request 2026-04-29 07:20:30 +00:00
a22erigr deleted branch #553-improve-style-selector 2026-05-11 18:20:48 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
a24noabe
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!629
No description provided.