847-enhance-settings #857

Merged

a24julot merged 4 commits from 847-enhance-settings into team_1_week_5

2026-05-11 08:16:08 +00:00

b24erika commented

2026-05-11 07:33:38 +00:00

Collaborator

The css for settings was overrided by themes, now it is not. Changed some css so that the distance between buttons/text where equal as well as the buttons having a min-width so the smallest has the same size as the others in the menu.

b24erika added the

frontEnd

Team 1

needs review

labels

2026-05-11 07:33:38 +00:00

b24erika self-assigned this

2026-05-11 07:33:38 +00:00

b24erika added 4 commits

2026-05-11 07:33:39 +00:00

changed classname variables c1a018e4b7

change min width buttons 4c9dc451f9

updated css desktop/phone 255ad27330

padding now has size of gap so that the distance between them seems more equal. Buttons has a min width to no limit longer named buttons, changed flex direction to row instead of column in phone, which resolve misplacement of text.

set state value as toolbarexpanded b0fa35606d

b24erika referenced this pull request

2026-05-11 07:35:07 +00:00

Enhance settings page #847

a24julot

2026-05-11 07:36:38 +00:00

added
Under-review
and removed
needs review
labels
requested review from a24hamrh

a24hamrh approved these changes

2026-05-11 08:01:26 +00:00

a24hamrh left a comment

Collaborator

Review on #857

Whats done

Tested on Windows 11 using Firefox

App starts
- The text and button distance looks good.

Inspected following files: Settings.js, Settings.module.css, Dashboard.js, Dashboard.module.css

All
- Indentation/code styling
  - Indentation is ok
- Naming convention
  - Naming convention is followed
- Comments
  - Comments are ok.
- General code quality
  - The general code quality is good.

Conclusion

The application starts and the distance between buttons/text looks good
The smallest size for the buttons looks good.

# Review on #857 ## Whats done ### Tested on Windows 11 using Firefox + App starts + The text and button distance looks good. ### Inspected following files: Settings.js, Settings.module.css, Dashboard.js, Dashboard.module.css + All + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Comments + Comments are ok. + General code quality + The general code quality is good. ## Conclusion + The application starts and the distance between buttons/text looks good + The smallest size for the buttons looks good.