Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

847-enhance-settings #857

Merged
a24julot merged 4 commits from 847-enhance-settings into team_1_week_5 2026-05-11 08:16:08 +00:00
Conversation 2 Commits 4 Files changed 4 +24 -21
b24erika commented 2026-05-11 07:33:38 +00:00
Collaborator
Copy link

The css for settings was overrided by themes, now it is not. Changed some css so that the distance between buttons/text where equal as well as the buttons having a min-width so the smallest has the same size as the others in the menu.

The css for settings was overrided by themes, now it is not. Changed some css so that the distance between buttons/text where equal as well as the buttons having a min-width so the smallest has the same size as the others in the menu.
padding now has size of gap so that the distance between them seems more equal. Buttons has a min width to no limit longer named buttons, changed flex direction to row instead of column in phone, which resolve misplacement of text.
a24julot 2026-05-11 07:36:38 +00:00
a24hamrh approved these changes 2026-05-11 08:01:26 +00:00
a24hamrh left a comment
Collaborator
Copy link

Review on #857

Whats done

Tested on Windows 11 using Firefox

  • App starts
    • The text and button distance looks good.

Inspected following files: Settings.js, Settings.module.css, Dashboard.js, Dashboard.module.css

  • All
    • Indentation/code styling
      • Indentation is ok
    • Naming convention
      • Naming convention is followed
    • Comments
      • Comments are ok.
    • General code quality
      • The general code quality is good.

Conclusion

  • The application starts and the distance between buttons/text looks good
  • The smallest size for the buttons looks good.
# Review on #857 ## Whats done ### Tested on Windows 11 using Firefox + App starts + The text and button distance looks good. ### Inspected following files: Settings.js, Settings.module.css, Dashboard.js, Dashboard.module.css + All + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Comments + Comments are ok. + General code quality + The general code quality is good. ## Conclusion + The application starts and the distance between buttons/text looks good + The smallest size for the buttons looks good.
a24julot commented 2026-05-11 08:16:01 +00:00
Collaborator
Copy link

Good job, this will be merged!

Good job, this will be merged!
a24julot merged commit 118445b2cd into team_1_week_5 2026-05-11 08:16:08 +00:00
c24danli deleted branch 847-enhance-settings 2026-05-21 13:22:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24hamrh
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b24erika
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!857
No description provided.