Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Added Playwright info to README #1049

Merged
a24julot merged 5 commits from write-in-wiki-about-the-playwrite-#1043 into team_1_week_7 2026-05-22 08:14:48 +00:00
Conversation 13 Commits 5 Files changed 7 +162 -61
e24aleli commented 2026-05-20 12:56:27 +00:00
Collaborator
Copy link
No description provided.
Added Playwright help to README
Some checks failed
Playwright Tests / test (pull_request) Has been cancelled
Details
5b60d33033
a22erigr changed target branch from main to team_1_week_7 2026-05-20 12:57:26 +00:00
f21marfo reviewed 2026-05-20 13:26:49 +00:00
f21marfo left a comment
Collaborator
Copy link

Either something is wrong on my end, or there is required information missing in the readme. Tried running the commands and had the following results.

Running npm run test:responsive did not work and generated the following terminal output.
image

npx playwright test --ui
Terminates with the following error.
image

npx playwright show-report
Seems to work, but just brings up old test results in the repository.
image

Either something is wrong on my end, or there is required information missing in the readme. Tried running the commands and had the following results. Running `npm run test:responsive` did not work and generated the following terminal output. ![image](/attachments/7a78f80b-d1d9-4cb1-a24e-6c4c07252034) npx playwright test --ui Terminates with the following error. ![image](/attachments/111ba16a-88e7-4fb0-bc90-da28c6fbb566) npx playwright show-report Seems to work, but just brings up old test results in the repository. ![image](/attachments/193002a4-0a76-459e-a5dd-522394c0bbfc)
image.png
14 KiB
image.png
57 KiB
image.png
471 KiB
e24aleli commented 2026-05-20 13:34:05 +00:00
Author
Collaborator
Copy link

I believe the problem is currently that we need playwright to be in the installation script so that it is installed on the computer because i had to run the following to make it work when i reinstalled after merge. This is sort of speculation as of now the test itself might need to be looked in to aswell its very simple..

# 1. Clear out your existing Playwright cache
npx playwright uninstall --all

# 2. Re-install fresh, validated browser binaries
npx playwright install firefox chromium webkit

# 3. Force dependency validation
npx playwright install-deps

Right now the directoríes that playwright creates after install is in the main branch i think we need to remove all regarding playwright except for the test dir and include it in the install script. This way the directories is correctly installed instead of being "pre-installed" when fetching a branch currently.

I believe the problem is currently that we need playwright to be in the installation script so that it is installed on the computer because i had to run the following to make it work when i reinstalled after merge. This is sort of speculation as of now the test itself might need to be looked in to aswell its very simple.. ``` # 1. Clear out your existing Playwright cache npx playwright uninstall --all # 2. Re-install fresh, validated browser binaries npx playwright install firefox chromium webkit # 3. Force dependency validation npx playwright install-deps ``` Right now the directoríes that playwright creates after install is in the main branch i think we need to remove all regarding playwright except for the test dir and include it in the install script. This way the directories is correctly installed instead of being "pre-installed" when fetching a branch currently.
f21marfo commented 2026-05-20 13:50:27 +00:00
Collaborator
Copy link

I just tried clearing out and reinstalling playwright, still can't seem to get the commands to work.

I just tried clearing out and reinstalling playwright, still can't seem to get the commands to work.
e24aleli commented 2026-05-20 14:17:55 +00:00
Author
Collaborator
Copy link

@f21marfo found the problem!!

Inside of package.json
it should say:image

for some reason on this branch and probably other ones its not there

@f21marfo found the problem!! Inside of `package.json` it should say:![image](/attachments/6f7fe93a-8e36-4a02-900d-e5ec89c7fbf0) for some reason on this branch and probably other ones its not there
image.png
9.5 KiB
f21marfo commented 2026-05-21 07:26:08 +00:00
Collaborator
Copy link

Still can't make it work, but now the first command gives a different error message.
image
Which is honestly puzzling, since "npx playwright show-report" does work, so obviously "playwright" isn't truly an unknown command.

npx playwright test --ui remains unchanged.

Still can't make it work, but now the first command gives a different error message. ![image](/attachments/503640f7-0843-4fc8-a0bf-d0610087ebb2) Which is honestly puzzling, since "npx playwright show-report" does work, so obviously "playwright" isn't truly an unknown command. npx playwright test --ui remains unchanged.
image.png
18 KiB
e24aleli commented 2026-05-21 08:55:03 +00:00
Author
Collaborator
Copy link

This is truly weird and you have tried to refetch the branch?

This is truly weird and you have tried to refetch the branch?
f21marfo commented 2026-05-21 09:02:26 +00:00
Collaborator
Copy link

Yes, even wiped and refetched everything and run the scripts, clean.

Yes, even wiped and refetched everything and run the scripts, clean.
a24sakma commented 2026-05-21 09:25:41 +00:00
Collaborator
Copy link

@e24aleli && @f21marfo
I think we have some issues that needs to be addressed.
so the libraries that gets installed. shall be in the package.json
the command that runs the script shall also be in the package
there shall be an example on the test that can be runned.

Right now those packages gets installed globally on your laptop and it is outside the project

@e24aleli && @f21marfo I think we have some issues that needs to be addressed. so the libraries that gets installed. shall be in the `package.json` the command that runs the script shall also be in the `package` there shall be an example on the test that can be runned. Right now those packages gets installed globally on your laptop and it is outside the project 
Otherwise manual install is necessary
f21marfo reviewed 2026-05-21 12:07:04 +00:00
f21marfo left a comment
Collaborator
Copy link

Follow-Up Review.

  • After pulling and building the latest changes, all three commands now execute without issue, on my system.
  • Readme should now accurately reflect how to run tests.

Though its worth noting the scope of the pull-request has grown from the original issue. On that point.

  • .gitignore "looks reasonable".
  • package.json appears to contain the required dependencies.
Follow-Up Review. + After pulling and building the latest changes, all three commands now execute without issue, on my system. + Readme should now accurately reflect how to run tests. Though its worth noting the scope of the pull-request has grown from the original issue. On that point. + .gitignore "looks reasonable". + package.json appears to contain the required dependencies.
a24sakma commented 2026-05-21 12:47:48 +00:00
Collaborator
Copy link

"npx playwright install" needs also to be added into package json scripts. I informed the developer.

"npx playwright install" needs also to be added into package json scripts. I informed the developer.
a24sakma approved these changes 2026-05-21 13:27:51 +00:00
a24sakma left a comment
Collaborator
Copy link

Great job!

Now it is more complete and automatiserade. I approve this pr

Great job! Now it is more complete and automatiserade. I approve this pr
f21marfo approved these changes 2026-05-21 13:41:23 +00:00
f21marfo left a comment
Collaborator
Copy link

Everything looks good after final set of fixes! Lets go!

Everything looks good after final set of fixes! Lets go!
a24julot commented 2026-05-22 08:14:43 +00:00
Collaborator
Copy link

Good job! I will merge this.

Good job! I will merge this.
a24julot merged commit 8b98743c86 into team_1_week_7 2026-05-22 08:14:48 +00:00
c24danli deleted branch write-in-wiki-about-the-playwrite-#1043 2026-05-22 12:25:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24sakma
f21marfo
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1049
No description provided.