#112 Research/test schedule card #137
No reviewers
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
No milestone
No project
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!137
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "#112-Card]-Research/test-schedule-card"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
added api to fetch data from timeedit. Added new view for the schedule
Related issue is "[Card] Research/test schedule card #112"
Comments do not follow set code standard, for example in useTimeedit it says "timestamp, temp" and in ScheduleView a single line comment is on 2 rows (Idk how correct that needs to be, could skip that bit and just change the first temp comment). Should only the next date be shown? I think more information/context is needed, such as which room is being shown or between what times. Looks good and works well otherwise!
Tested the branch locally and it worked very well. Has informed the developer that we need unit testing before initialisation of merge commmit.
Working on it
Because Breakout of duplicate code in frontend/src/features #159 refactors the function that needed unit test in to one shared function only unit test for the shared function was deemed necessary. A new branch was created from this one. The refactoring implemented and adhering unit tests
Important: This branch should only be merged into team_2_week_1 after following merge is complete #159 Refactored code to use DRY and added test #163