#112 Research/test schedule card #137

Merged
c24elipe merged 9 commits from #112-Card]-Research/test-schedule-card into team_2_week_1 2026-04-09 07:40:14 +00:00
Collaborator

added api to fetch data from timeedit. Added new view for the schedule

added api to fetch data from timeedit. Added new view for the schedule
added api to fetch data from timeedit. Added new view for the schedule
Collaborator

Related issue is "[Card] Research/test schedule card #112"

Related issue is "[Card] Research/test schedule card #112"
Collaborator

Comments do not follow set code standard, for example in useTimeedit it says "timestamp, temp" and in ScheduleView a single line comment is on 2 rows (Idk how correct that needs to be, could skip that bit and just change the first temp comment). Should only the next date be shown? I think more information/context is needed, such as which room is being shown or between what times. Looks good and works well otherwise!

Comments do not follow set code standard, for example in useTimeedit it says "timestamp, temp" and in ScheduleView a single line comment is on 2 rows (Idk how correct that needs to be, could skip that bit and just change the first temp comment). Should only the next date be shown? I think more information/context is needed, such as which room is being shown or between what times. Looks good and works well otherwise!
The feedback from the first pull request has been fixed (Comments not
following standard)
a22erigr changed target branch from main to team_2_week_1 2026-04-07 07:39:43 +00:00
Collaborator

Tested the branch locally and it worked very well. Has informed the developer that we need unit testing before initialisation of merge commmit.

Tested the branch locally and it worked very well. Has informed the developer that we need unit testing before initialisation of merge commmit.
Author
Collaborator

Working on it

Working on it
Author
Collaborator

Because Breakout of duplicate code in frontend/src/features #159 refactors the function that needed unit test in to one shared function only unit test for the shared function was deemed necessary. A new branch was created from this one. The refactoring implemented and adhering unit tests

Because [ Breakout of duplicate code in frontend/src/features #159 ](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/159) refactors the function that needed unit test in to one shared function only unit test for the shared function was deemed necessary. A new branch was created from this one. The refactoring implemented and adhering unit tests
Author
Collaborator

Important: This branch should only be merged into team_2_week_1 after following merge is complete #159 Refactored code to use DRY and added test #163

**Important:** This branch should only be merged into team_2_week_1 after following merge is complete [ #159 Refactored code to use DRY and added test #163 ](https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/163)
testing the shared apifetch function
- Name change: SharedFetures.js ->SharedFeatures.js
 - Change import in effected file
- Implemented unit test for failure case
 - Error 500
- Removed debug code
I just capitalized "UseApi" and the description to comply with the coding standard.
Reviewed-on: #163
c24elipe merged commit e8cff73e06 into team_2_week_1 2026-04-09 07:40:14 +00:00
c24elipe deleted branch #112-Card]-Research/test-schedule-card 2026-04-09 07:40:15 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!137
No description provided.