Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#159 Refactored code to use DRY and added test #163

Merged
c24elipe merged 5 commits from #159-Breakout-of-duplicate-code-in-frontend/src/features into #112-Card]-Research/test-schedule-card 2026-04-09 07:37:30 +00:00
Conversation 3 Commits 5 Files changed 8 +102 -47
a22erigr commented 2026-04-07 13:44:07 +00:00
Collaborator
Copy link
No description provided.
c24elipe commented 2026-04-08 07:42:35 +00:00
Collaborator
Copy link

Besides the small name change, look good to me!

Besides the small name change, look good to me!
testing the shared apifetch function
c24carso removed their assignment 2026-04-08 10:58:13 +00:00
c24carso commented 2026-04-08 11:31:32 +00:00
Collaborator
Copy link

What i've reviewed:
All changes across the files.

Issues found:
Filename has a typo (SharedFetures.js should be SharedFeatures.js) on all files.
Only tests success cases no failure cases.
Testing name doesn't follow the testing guidelines(MethodName_StateUnderTest_ExpectedBehavior).
Debug code should not be merged. (console.log('NU SKA JAG TESTA ') )

Checks performed:
Reviewed code quality.
Verified that it keeps the same functionality as old test.
Checked against the standards set by the wiki.
Could not pull and try locally as i had no access to branch.

What i've reviewed: All changes across the files. Issues found: Filename has a typo (SharedFetures.js should be SharedFeatures.js) on all files. Only tests success cases no failure cases. Testing name doesn't follow the testing guidelines(MethodName_StateUnderTest_ExpectedBehavior). Debug code should not be merged. (console.log('NU SKA JAG TESTA ') ) Checks performed: Reviewed code quality. Verified that it keeps the same functionality as old test. Checked against the standards set by the wiki. Could not pull and try locally as i had no access to branch.
a22erigr commented 2026-04-08 12:48:11 +00:00
Author
Collaborator
Copy link

Working on it

Working on it 
- Name change: SharedFetures.js ->SharedFeatures.js
 - Change import in effected file
- Implemented unit test for failure case
 - Error 500
- Removed debug code
I just capitalized "UseApi" and the description to comply with the coding standard.
c24elipe merged commit 46838af161 into #112-Card]-Research/test-schedule-card 2026-04-09 07:37:30 +00:00
c24elipe deleted branch #159-Breakout-of-duplicate-code-in-frontend/src/features 2026-04-09 07:38:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
c24carso
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!163
No description provided.