issue#7-multipleTemperatureMockSensors

c24danli commented

2026-04-10 09:34:19 +00:00

Collaborator

/tempSensorMockup

added multiple sensors as an arrya insted of one singular as before (creates sensors and mockdata)
/tempSensorMockup
readTempSensorMockup
chaged to read an list of sensors insted of one object (reads sensors and adds to db)
/tempService
changed to be able to handle a parameter to get the specific sensor when querring the db(The Api/querry from db to get the data)
/frontend/src/features/temperature
added the view TemperatureTimeSeriesView and hook useTemperatureTimeSeriesView to show historic data with parameter for specifc sensor
changed TemperatureView and useTemperatureView to handle a parameter in the querry

Parprograming with a22erigr

/tempSensorMockup - added multiple sensors as an arrya insted of one singular as before (creates sensors and mockdata) /tempSensorMockup - readTempSensorMockup - chaged to read an list of sensors insted of one object (reads sensors and adds to db) /tempService - changed to be able to handle a parameter to get the specific sensor when querring the db(The Api/querry from db to get the data) /frontend/src/features/temperature - added the view TemperatureTimeSeriesView and hook useTemperatureTimeSeriesView to show historic data with parameter for specifc sensor - changed TemperatureView and useTemperatureView to handle a parameter in the querry Parprograming with a22erigr

c24danli added 7 commits

2026-04-10 09:34:19 +00:00

Changes related to mockup data 3a3f230143

/TempSensorMockup
var data= new{sensor1} chaged to var data= new[]{sensor1,sensor2..}
It used to give back a object with data of a single sensor now it returns an array with data from multiple sensors
/readTempSensorMockup
the read function used to expect an single object from tempSensorMockup but as its an array now its been changed to expect an array and a foreach loop have been intruduced to read and store the data from all sensors in the array
/tempService
i have included the sensorId in the class TempratureData, even if we stored sensorId,timestamp and temperature in the db we could only use the last two before in the View's/app it doesnt do anything now but its added to be able to make out witch sensor gives the reading.

add hook for timeseries 2f3bacd429

Added view for timeseries 2bdcaf89ea

Added to view to app 97c13cc700

Work in progress c1c790de33

we can save data from diffrent sensors and get it, but we have to be able to sort the data from diffrent sensors witch is the next problem.
Parprograming with: a22erigr

Calling the Views with params 665f2776ea

The api for both single and and entire history works when not using params to choose sensor
Latest- works with params as well to get from a specific sensor
all- doesnt work when choosing a specific sensor with params, it gets the param as unnown when we try to send it along

par programing with a22erigr

Issue with historic data for specific sensor fixed 7ff094b2d8

The Issue#7 and #12 is implimented in this branch, we can now create as manny mock sensors as we like, save the data to the db and querry it for either the latest temp or historic temp for each sensor seperatly.
If the historic data is going to be used it still needs to be filtered/sliced to get the intervalls and amount of data points wanted

c24elipe added the

needs review

label

2026-04-10 09:34:51 +00:00

c24elipe self-assigned this

2026-04-10 09:44:50 +00:00

c22abdal was assigned by c24elipe

2026-04-10 09:44:50 +00:00

c24elipe removed their assignment

2026-04-10 09:44:54 +00:00

c22abdal commented

2026-04-10 12:22:52 +00:00

Collaborator

Overall, everything seems fine and working, there are only a few comment issues that were addressed directly to the developer but shouldn't cause an issue.
And in the useTempreatureTimeSeriesView.js the useEffect should probably return sensorId as a dependency to ensure that switching between sensors refetches the hook, if i understood it correctly this is a problem. that should be fixed

so change from

useEffect(() => {
    fetch(API_URL + sensorId)
      .then(res => {
        if (!res.ok) throw new Error(`HTTP ${res.status}`);
        return res.json();
      })
      .then(json => {
        setData(json);
        setError(null);
      })
      .catch(err => setError(err.message))
      .finally(() => setLoading(false));
  }, []);

to:

useEffect(() => {
    fetch(API_URL + sensorId)
      .then(res => {
        if (!res.ok) throw new Error(`HTTP ${res.status}`);
        return res.json();
      })
      .then(json => {
        setData(json);
        setError(null);
      })
      .catch(err => setError(err.message))
      .finally(() => setLoading(false));
  }, [sensorId]); // this line !! ----------------------

Overall, everything seems fine and working, there are only a few comment issues that were addressed directly to the developer but shouldn't cause an issue. And in the useTempreatureTimeSeriesView.js the useEffect should probably return _sensorId_ as a dependency to ensure that switching between sensors refetches the hook, if i understood it correctly this is a problem. that should be fixed so change from ``` useEffect(() => { fetch(API_URL + sensorId) .then(res => { if (!res.ok) throw new Error(`HTTP ${res.status}`); return res.json(); }) .then(json => { setData(json); setError(null); }) .catch(err => setError(err.message)) .finally(() => setLoading(false)); }, []); ``` to: ``` useEffect(() => { fetch(API_URL + sensorId) .then(res => { if (!res.ok) throw new Error(`HTTP ${res.status}`); return res.json(); }) .then(json => { setData(json); setError(null); }) .catch(err => setError(err.message)) .finally(() => setLoading(false)); }, [sensorId]); // this line !! ---------------------- ```

c22abdal added

reviewed

and removed

needs review

labels

2026-04-10 12:23:09 +00:00

a22erigr was assigned by c24elipe

2026-04-10 13:18:53 +00:00

a22erigr commented

2026-04-10 13:19:45 +00:00

Collaborator

Parprograming the feature with c24danli. The commit and pull were made from his computer.

a22erigr added 1 commit

2026-04-10 14:18:30 +00:00

Fixes after review 76006f997a

+ Dependency for api
+ change indentation to follow standard
+ Removed out commented code
+ Added comments to explain the code
+ Incerted found no result logic

c24elipe added 1 commit

2026-04-10 15:22:28 +00:00