Andras/BoundlessFlowCampus2K

Fork 0

add centralized view size config with default and custom rules #410

Merged

c24elipe merged 2 commits from 252-enforce-view-settings-in-grid into team_2_week_2

2026-04-20 12:09:31 +00:00

b25marem commented

2026-04-17 11:57:34 +00:00

Collaborator

Result
All views now receive size constraints automatically
Specific views can override default behavior when needed
Improved consistency and maintainability of grid layout

Notes
Views that do not have custom config fall back to default settings
No manual size configuration is required when adding new views

Implemented centralized configuration for view size settings in the grid. What was done Added a default configuration (DEFAULT_VIEW_CONFIG) for consistent sizing across all views Added custom configurations for specific views that require different size constraints Implemented responsive breakpoints (lg, md, sm, xs, xxs) based on container width Created a helper function (getViewSizeConfig) to dynamically apply the correct configuration Integrated the configuration system into Dashboard when adding new views Result All views now receive size constraints automatically Specific views can override default behavior when needed Improved consistency and maintainability of grid layout Notes Views that do not have custom config fall back to default settings No manual size configuration is required when adding new views

b25marem added the

needs review

label

2026-04-17 11:57:34 +00:00

b25marem added 1 commit

2026-04-17 11:57:34 +00:00

add centralized view size config with default and custom rules 475b20479a

b23albst referenced this pull request

2026-04-17 13:30:58 +00:00

Certain views/cards scale with text when added, but moving them scales them to default size #374

c24elipe requested review from b23albst

2026-04-20 08:48:18 +00:00

b25marem was assigned by c24elipe

2026-04-20 08:48:26 +00:00

b23albst commented

2026-04-20 10:06:18 +00:00

Collaborator

Review on #252

Whats done

I checked that the code follows the standards and that the addition of of view config did not break any part of the application.

Tested on ubuntu using firefox

App starts
- Tested so that most basic functionality is intact (adding views, moving, resizing, etc.)
- For the most part, everything works as intended, but it seems like if you move a card before resizing it, it falls back to the default size config, which is really noticeable with map and parking view, as the content overflows out of the card. If you resize the card first, you can move it without affecting the view config, as long as you do not add other cards. However, I suspect that this issue occurs since the cards variables (h, w and such) are not updated when changed, something addressed in pr #398.

(Top card was moved before resized and can not be changed to have the same hight as the bottom card, which leads me to believe that this is caused by it having a different size config)

Inspected following files

frontend/src/viewConfig.js
- Indentation/code styling is ok
- Naming convention is ok
- Comments
  - There are no comments in the file, but I have no problem with this, as the code is clear nonetheless.

What needs to be done

I think the issue that occurs when a card is moved might need to be looked at, but as stated earlier, it could already be solved in team 1's branch. If this persists after the weekly merge, I think it should be added as it's own issue.

Conclusion

I think this ready to be merged

# Review on #252 ## Whats done I checked that the code follows the standards and that the addition of of view config did not break any part of the application. ### Tested on ubuntu using firefox + App starts + Tested so that most basic functionality is intact (adding views, moving, resizing, etc.) + For the most part, everything works as intended, but it seems like if you move a card before resizing it, it falls back to the default size config, which is really noticeable with map and parking view, as the content overflows out of the card. If you resize the card first, you can move it without affecting the view config, as long as you do not add other cards. However, I suspect that this issue occurs since the cards variables (h, w and such) are not updated when changed, something addressed in pr #398. ![image](/attachments/6504e66d-71c6-4ce3-a061-79fa95a0a5f4) (Top card was moved before resized and can not be changed to have the same hight as the bottom card, which leads me to believe that this is caused by it having a different size config) ### Inspected following files + frontend/src/viewConfig.js + Indentation/code styling is ok + Naming convention is ok + Comments + There are no comments in the file, but I have no problem with this, as the code is clear nonetheless. ## What needs to be done + I think the issue that occurs when a card is moved might need to be looked at, but as stated earlier, it could already be solved in team 1's branch. If this persists after the weekly merge, I think it should be added as it's own issue. ## Conclusion + I think this ready to be merged

image.png

26 KiB

👍 1

b23albst added

reviewed

and removed

needs review

labels

2026-04-20 10:08:42 +00:00

c24elipe added 1 commit

2026-04-20 12:07:53 +00:00