#439-Dragging-card-beyond-limit #457
No reviewers
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!457
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "439-Dragging-card-beyond-limit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Added to line 86 in Dashboard.js to stop it from scrolling horizontaly when you drag an card outside of the bounds
added style={{ overflowX: 'hidden', width: '100%' }} to the <div class='Dashboard Parent Div' > will check tomorrow how it behaves with diffrent sized screens and if it works add to css style fileOnly aadded "style={{ overflowX: 'hidden', width: '100%' }} // to fix drag problem horizontoly add in css later" to the dashboard div will let i be in inline for now as we will probebly look over the structure of the css files in our project439-Dragging-card-beyond-limitto #439-Dragging-card-beyond-limitI have first reviewed team_2_week_2 branch to see the issue which was that you can pull cards horizontally beyond the grid. Then I switched to 439-Dragging-card-beyond-limit branch to see if this issue has been solved. The issue has not been fully solved. I can still pull the cards to the right but the only difference is that the scrollbar is no longer visible.
I checked the Dashboard.js and reviewed the changes made which were adding "style={{ overflowX: 'hidden', width: '100%' }}". This appears to only hide the content which is outside of the grid rather than actually preventing to pull the cards to the right.
In conclusion this PR cannot be merged right now as it is not yet complete as it only partially solves the problem.
The fix is not perfect but have been approved by TL to merge.
Ok!