Disable-X-Overflow-#593 #594

Merged
b24johka merged 1 commit from Disable-X-Overflow-#593 into team_1_week_3 2026-04-27 20:46:15 +00:00
Collaborator

Created an app.css for the settings to all of the website and have overflow X hidden

Created an app.css for the settings to all of the website and have overflow X hidden
overflow on card so that buttons stay in place, now views inside cards wont be displayed outside off it.
Reviewed-on: #514
- Broke out the toggle switch into its own component and style sheet.'
+ Created ToggleButton folder containing ToggleButton.js and ToggleButton.module.css.
+ Updated /components/index.js to export new ToggleButton
- Integrated it with Dashboard.js.
- Removed toggle switch entries from Dashboard.module.css.
This was by mistake merged to the temp branch
Commit includes updating index to import tooltip, change Card.js so overflow is put on an seperate div so scroll do not cover whole card. Removed css for tooltip since it messed up the buttonpanel. New css for dashboard, removebutton style is removed and put in css as well as css for buttonpanel and their items
fixed scaling for cards.
Reviewed-on: #518
Reviewed-on: #503
all current views now have their own output when hovering the tooltip symbol.
Reviewed-on: #530
Reviewed-on: #568
Reviewed-by: Vincent Lamppa Lönnbro <a24vinla@noreply.localhost>
b24johka changed target branch from team_2_week_3 to team_1_week_3 2026-04-27 11:41:05 +00:00
Author
Collaborator

Ignore the commit history, i think it was because i targeted the wrong branch. But i am uncertain.

Ignore the commit history, i think it was because i targeted the wrong branch. But i am uncertain.
Author
Collaborator

This is the issue being fixed

This is the issue being fixed
Collaborator

Review on #539

Whats done

Reviewed #593

Tested on Windows 11 using Firefox

  • App starts
    • Checked to see if content is hidden when overflowing to the left/right.

Inspected following files App.js, app.css

  • Both files
    • Indentation/code styling
      • Indentation is ok
    • Naming convention
      • Naming convention is followed
    • Comments
      • There are no comments but not if its needed.
    • General code quality
      • The general code quality is good.

Conclusion

  • Everything works as intended and code executes.
# Review on #539 ## Whats done Reviewed #593 ### Tested on Windows 11 using Firefox + App starts + Checked to see if content is hidden when overflowing to the left/right. ### Inspected following files App.js, app.css + Both files + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Comments + There are no comments but not if its needed. + General code quality + The general code quality is good. ## Conclusion + Everything works as intended and code executes.
Author
Collaborator

Minor fix and the review is very sufficient. This will be merged right away.

Minor fix and the review is very sufficient. This will be merged right away.
b24johka merged commit 3cd0f276b2 into team_1_week_3 2026-04-27 20:46:15 +00:00
b24johka deleted branch Disable-X-Overflow-#593 2026-04-27 20:47:47 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!594
No description provided.