Andras/BoundlessFlowCampus2K

Fork 0

#576 Created Support page skeleton #595

Merged

c24elipe merged 3 commits from #-576-support-page into team_2_week_3

2026-04-28 07:57:25 +00:00

c22abdal commented

2026-04-27 11:56:32 +00:00

Collaborator

Created a skeleton for the support page with main university links (portal and university websites).
Files changed:

app.js
- Just referenced the support page add a new line to import the page (to avoid conflicts)
footer.js
- Added the page to the button

Support.js
Support.module.css

by no means is the style of the page finalized. it's just a touch and should probably be changed later

Created a skeleton for the support page with main university links (portal and university websites). Files changed: - app.js - Just referenced the support page add a new line to import the page (to avoid conflicts) - footer.js - Added the page to the button + Support.js + Support.module.css by no means is the style of the page finalized. it's just a touch and should probably be changed later

c22abdal added the

needs review

label

2026-04-27 11:56:32 +00:00

c22abdal added 1 commit

2026-04-27 11:56:33 +00:00

Created Support page skeleton 2104d4062c

c22abdal was assigned by c24elipe

2026-04-27 13:21:50 +00:00

c24elipe requested review from c24elipe

2026-04-27 13:39:19 +00:00

c24elipe changed title from ~~Created Support page skeleton~~ to #576- Created Support page skeleton

2026-04-27 13:40:51 +00:00

c24elipe changed title from ~~#576- Created Support page skeleton~~ to #576 Created Support page skeleton

2026-04-27 13:40:56 +00:00

c24elipe requested changes

2026-04-27 14:30:20 +00:00

Dismissed

c24elipe left a comment

Collaborator

Review on #559

Whats done

Reviewed the cleanup of

app.js
footer.j, s
frontend/src/pages/Support.js,
frontend/src/pages/Support.module.css
for issue #576

Tested on Arch Linux using Brave and Firefox

Tests:
* Running the code with NPM run
- Inspected the code in my code editor and with prettier
- Open the site in the Brave and Firefox browsers.

Inspected the following files

app.js:
* Indentation/code styling
* Clean
- Comments
  * No new additions (not an issue)
* General code quality
* *Improvements to add:
* None
* Issues:
* Once again, none noticed.
footer.js:
* Indentation/code styling
* Clean
* Comments
* No new additions (not an issue)
* General code quality:
* Improvements to add:
     * I would like to see the text "FAQ(Placeholder)" in the footer to be changed to something like "Support and FAQ" or similar to signal that the site exists.

   * Issues:
     * Once again, none noticed.
Support.js:

* Indentation/code styling
* It follows prettier

* Comments
* A few added, but they are well placed and make up for quantity with quality... minus the "Please remove !! this is just a joke" part. That came off as too jokey a comment.

* General code quality:
   * Improvements to add:
   * Possible improvements could be to change the spacing between or turn the FQA text into buttons.

   * And also, to make a text fold-out if the corresponding button is pressed.

* Issues:
* Update the comment to be something more fitting. But the section being commented on can stay.

Support.module.css:

* Indentation/code styling
* It follows prettier
* Comments
* No problems here either. They are fitting. However, just to be a little pedantic, I would like to see comments for ".support-page p" and ".support-item:last-child". With this, the whole CSS would be commented.
* General code quality:
* Improvements to add:
     * Nothing, besides the comment thing.
   * Issues:
     * Again, the comment coverage problem. Besides that, not.

What needs to be done

Support.js
* Update the "Please remove !! this is just a joke" comment.
Support.module.css
* Give one basic comment for both ".support-page p" and ".support-item:last-child".

Conclusion

After the described things have been done. After that, it can be merged without a problem.

# **Review on \#559** ![image](/attachments/60181fed-db45-4944-8e6d-ec933be02eb7) ## **Whats done** Reviewed the cleanup of * app.js * footer.j, s * frontend/src/pages/Support.js, * frontend/src/pages/Support.module.css for issue \#576 ### **Tested on Arch Linux using Brave and Firefox** * Tests: * Running the code with NPM run * Inspected the code in my code editor and with prettier * Open the site in the Brave and Firefox browsers. ### **Inspected the following files** * **app.js**: * **Indentation/code styling** * Clean * **Comments** * No new additions (not an issue) * **General code quality** * ***Improvements to add**: * None * **Issues**: * Once again, none noticed. * **footer.js**: * **Indentation/code styling** * Clean * **Comments** * No new additions (not an issue) * **General code quality:** * **Improvements to add**: * I would like to see the text "FAQ(Placeholder)" in the footer to be changed to something like "Support and FAQ" or similar to signal that the site exists. ![image](/attachments/0b08f6bb-4fb7-462e-88e7-a407ebb4f0e9) * **Issues**: * Once again, none noticed. * **Support.js**: * **Indentation/code styling** * It follows prettier * **Comments** * A few added, but they are well placed and make up for quantity with quality... minus the "Please remove \!\! this is just a joke" part. That came off as too jokey a comment. * **General code quality**: * **Improvements to add**: * Possible improvements could be to change the spacing between or turn the FQA text into buttons. * And also, to make a text fold-out if the corresponding button is pressed. * **Issues:** * Update the comment to be something more fitting. But the section being commented on can stay. * **Support.module.css**: * **Indentation/code styling** * It follows prettier * **Comments** * No problems here either. They are fitting. However, just to be a little pedantic, I would like to see comments for ".support-page p" and ".support-item:last-child". With this, the whole CSS would be commented. * **General code quality:** * **Improvements to add:** * Nothing, besides the comment thing. * **Issues:** * Again, the comment coverage problem. Besides that, not. ## **What needs to be done** * **Support.js** * Update the "Please remove \!\! this is just a joke" comment. * **Support.module.css** * Give one basic comment for both ".support-page p" and ".support-item:last-child". ## **Conclusion** After the described things have been done. After that, it can be merged without a problem.

image.png

65 KiB

image.png

25 KiB

c22abdal added 1 commit

2026-04-27 17:47:29 +00:00

Review fixes f1eb9a313a