708-hamburger-position #738

Merged

a24julot merged 3 commits from 708-hamburger-position into team_1_week_4

2026-05-05 10:15:35 +00:00

b24erika commented

2026-05-05 08:57:52 +00:00

Collaborator

now hamburger menu is not "hardcoded" to a position, it follows the height of navbar with 1rem (padding of navbar) off so it wont be placed over the navbar itself. Re-structured divs from navbar to hamburger so that "child-divs" knows it parents.

b24erika added the

frontEnd

Team 1

needs review

labels

2026-05-05 08:57:52 +00:00

b24erika self-assigned this

2026-05-05 08:57:52 +00:00

b24erika added 1 commit

2026-05-05 08:57:53 +00:00

updated css b38046ad8b

now hamburger menu is not "hardcoded" to a position, it follows the height of navbar with 2vh off so it wont be placed over the navbar itself.

b24erika referenced this pull request

2026-05-05 08:59:49 +00:00

Update HamburgerMenu's position #708

a24julot requested review from a24hamrh

2026-05-05 09:23:27 +00:00

b24erika added 1 commit

2026-05-05 09:33:25 +00:00

increased distance from navbar e2ece2e878

b24erika added 1 commit

2026-05-05 09:40:19 +00:00

changed vh to rem 8630019cae

since navbar use 1rem in padding

a24hamrh commented

2026-05-05 10:11:03 +00:00

Collaborator

Review on #738

Whats done

Tested on Windows 11 using Firefox

App starts
- Open the hamburger menu and it starts where the navbar ends.

all inspected files
- Indentation/code styling
  - Indentation is ok
- Naming convention
  - Naming convention is followed
- Comments
  - Good amounts of comments
- General code quality
  - The general code quality is good.

Conclusion

The code looks good and it works as expected.

# Review on #738 ## Whats done ### Tested on Windows 11 using Firefox + App starts + Open the hamburger menu and it starts where the navbar ends. ### Inspected following files: app.css, HamburgurMenu.js, HamburgurMenu.module.css, Navbar.js, Navbar.module.css + all inspected files + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Comments + Good amounts of comments + General code quality + The general code quality is good. ## Conclusion + The code looks good and it works as expected.