Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#305-fileService #896

Closed
a24noabe wants to merge 13 commits from #305-fileService into team_2_week_5
pull from: #305-fileService
merge into: Andras:team_2_week_5
Conversation 7 Commits 13 Files changed 20 +581 -2
a24noabe commented 2026-05-11 13:37:05 +00:00
Collaborator
Copy link

FileService

Implemented a service allowing users to upload and download files to a server accessible through http.

Endpoints

Endpoint Description Request body
GET /f/{id} Fetch a file None
POST /upload/ Upload a file A file (<1MB)

Adress

The service is available at /api/files/.
/f/{id} expects the uuid of an uploaded file. It returns the file as an inline file instead of as a downloadable.
/upload/ expects a file, currently only .jpg, .jpeg, and .png files are allowed. The allowed file-types, their corresponding HTTP contenttypes, and their file signatures are added in FileService.cs.
Currently, it doesn't check whether a user is logged in, this functionality will be added once the use of tokens is implemented.
In order to test it, i recommend using an html file:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Test</title>
</head>
<body>
    <form action="http://localhost/api/files/upload/" method="post" enctype="multipart/form-data">
        <input type="file" name="image" id="image">
        <button type="submit">Upload</button>
    </form>
</body>
</html>

If the file is uploaded successfully you will get a response like:
image
The name is used at the /f/{id} endpoint, and you can see your image if you go there.

I haven't changed any scripts, so you will have to build the docker image (docker build -t fileservice .) in BoundlessFlowCampus2K\service\fileService\fileService. After you've done this you can run the rebuild script and then the compose file.
Since the endpoints are unsecure, we might have to remove it from the compose file so we don't run it on our server until we have authentication implemented.

# FileService Implemented a service allowing users to upload and download files to a server accessible through http. ## Endpoints | Endpoint | Description | Request body | |---|---|---| | `GET /f/{id}` | Fetch a file | None | | `POST /upload/` | Upload a file | A file (<1MB) | ## Adress The service is available at /api/files/. `/f/{id}` expects the uuid of an uploaded file. It returns the file as an inline file instead of as a downloadable. `/upload/` expects a file, currently only .jpg, .jpeg, and .png files are allowed. The allowed file-types, their corresponding HTTP contenttypes, and their file signatures are added in FileService.cs. Currently, it doesn't check whether a user is logged in, this functionality will be added once the use of tokens is implemented. In order to test it, i recommend using an html file: ```html <!DOCTYPE html> <html lang="en"> <head> <meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <title>Test</title> </head> <body> <form action="http://localhost/api/files/upload/" method="post" enctype="multipart/form-data"> <input type="file" name="image" id="image"> <button type="submit">Upload</button> </form> </body> </html> ``` If the file is uploaded successfully you will get a response like: ![image](/attachments/c1c5146d-037f-4d61-afcf-b76384875fa8) The name is used at the `/f/{id}` endpoint, and you can see your image if you go there. I haven't changed any scripts, so you will have to build the docker image (`docker build -t fileservice .`) in `BoundlessFlowCampus2K\service\fileService\fileService`. After you've done this you can run the rebuild script and then the compose file. Since the endpoints are unsecure, we might have to remove it from the compose file so we don't run it on our server until we have authentication implemented.
image.png
3.9 KiB
🚀 1 
Ripped straight from tempService.
Nothing done at this point. will get worked on.
The API endpoints now run, but they don't return images or allow for uploading yet. I've implemented some file validation for the upload to make sure that the files uploaded isn't an exe masquerading as an image file. There is also some debugging code in there but it's commented as such for easy removal. There are improvements to be made
lots of code (unreadable)
a24vinla reviewed 2026-05-12 06:42:45 +00:00
DockerCompose/init_sql/03-files.sql Outdated
@ -0,0 +1,34 @@
CREATE DATABASE files; -- Creates and uses the user database for the rest of file
a24vinla commented 2026-05-12 06:42:44 +00:00
Collaborator
Copy link

This, or the existing 03-sensors-cron-jobs.sql file, will have to be renamed

This, or the existing 03-sensors-cron-jobs.sql file, will have to be renamed
c22abdal commented 2026-05-12 11:00:52 +00:00
Collaborator
Copy link

Everything works well and beautifully.
Every changed file is clean, readable, and populated with comments to explain the logic.

I do wonder if the test file should be filled now?

The only thing to improve is probably in the C# files, all the code is clean but to increase the readability, add at least one empty line between the functions/method, also you will be following the code standards.

Once the code standards are followed, this pull request can be merged.

Everything works well and beautifully. Every changed file is clean, readable, and populated with comments to explain the logic. I do wonder if the test file should be filled now? The only thing to improve is probably in the C# files, all the code is clean but to increase the readability, add at least one empty line between the functions/method, also you will be following the code standards. Once the code standards are followed, this pull request can be merged.
a22erigr commented 2026-05-12 11:27:31 +00:00
Collaborator
Copy link

This should not be merged

The developer want to do some changes before merge.

## This should not be merged The developer want to do some changes before merge. 
This reverts commit 6e81f26bcd.
c24elipe commented 2026-05-13 07:52:09 +00:00
Collaborator
Copy link

image

![image](/attachments/8163ba6b-f0ed-4941-9725-6d386b98ed31)
image.png
7.2 KiB
c24elipe commented 2026-05-13 08:01:14 +00:00
Collaborator
Copy link

image

![image](/attachments/a2f3dba4-0a23-4a66-b2b3-3713480b5362)
image.png
21 KiB
a24vinla reviewed 2026-05-13 08:08:52 +00:00
service/fileService/fileService/Program.cs
@ -0,0 +14,4 @@
string DbUser = Environment.GetEnvironmentVariable("DATABASE_USER");
string DbPassword = Environment.GetEnvironmentVariable("DATABASE_PASSWORD");
string ConnectionString = $"Host=PostgreSQL;Port=5432;Database=sensors;Username={DbUser};Password={DbPassword}";
a24vinla commented 2026-05-13 08:08:52 +00:00
Collaborator
Copy link

Why does file service connect to sensors DB?

Why does file service connect to sensors DB?
a22erigr commented 2026-05-13 08:19:22 +00:00
Collaborator
Copy link

We don't get it to work . Fix issues and merge in next week branch

## We don't get it to work . Fix issues and merge in next week branch
a22erigr closed this pull request 2026-05-13 08:19:22 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
c22abdal
c24elipe
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!896
No description provided.