Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 142 Pull requests 15 Projects Releases Packages Wiki Activity Actions 2

Issue #108 [Card] Research/test display text card #182

Closed
a24hamrh wants to merge 0 commits from 108-Research-test-display-text-card into temp-week-2-merge-branch
pull from: 108-Research-test-display-text-card
merge into: Andras:temp-week-2-merge-branch
Conversation 5 Commits - Files changed -
a24hamrh commented 2026-04-08 12:26:09 +00:00
Collaborator
Copy link

Solution:
Made a view for viewing text elements.
Pair-programming with Nedzad (a24nedka)

Changes:
made file TextView.js under features/temperature

Notes:
The titel is set to Textview and the text element is lorem ipsum which needs to be changed when we have mockupdata.

Solution: Made a view for viewing text elements. Pair-programming with Nedzad (a24nedka) Changes: made file TextView.js under features/temperature Notes: The titel is set to Textview and the text element is lorem ipsum which needs to be changed when we have mockupdata.
Solution:
Made a view for viewing text elements.

Changes
made file TextView.js under features/temperature

Notes
The titel is set to Textview and the text element is lorem ipsum which needs to be changed when we have mockupdata.
a24hamrh changed title from Issue #108 to Issue #108 [Card] Research/test display text card 2026-04-08 12:39:15 +00:00
b24idalu commented 2026-04-09 09:15:52 +00:00
Collaborator
Copy link

Try to keep stuff in english for easier documentation.
Since this view also does not have anything to do with the temperature view, it should have its own map.
Feels like a kind of confusing issue, does not add a lot to the project from what I can tell? Do not know if it is worth merging or just keeping as documentation for now.

Try to keep stuff in english for easier documentation. Since this view also does not have anything to do with the temperature view, it should have its own map. Feels like a kind of confusing issue, does not add a lot to the project from what I can tell? Do not know if it is worth merging or just keeping as documentation for now.
Moved the file TextView.js to features/text.
Implemented the TextView in app.js so you can see the changes.
I kept the lorem ipsum text since it is commonly used as a placeholder for text.
a24vinla commented 2026-04-10 06:44:36 +00:00
Collaborator
Copy link

I think that the goal of this card was not to only display text, rather being able to add text to the card in a text field, like notes. I should have been more clear about that, sorry!

I think that the goal of this card was not to only display text, rather being able to add text to the card in a text field, like notes. I should have been more clear about that, sorry!
Made a text-field which you can edit by clicking on it.
f21marfo commented 2026-04-14 08:53:04 +00:00
Collaborator
Copy link

Review:

Code appears to execute as intended, nothing breaks. An editable text field appears under the temperature card in the app.
Code appears to follow to established coding standards for the most part. Naming conventions, spacing looks good.

However, lack of comments in the code makes it difficult to get a quick overview on what the different code sections actually "do", especially for those unfamiliar with the particulars of react, etc.

Recommendation: No obstacles exist to proceed with the merge, but do recommend adding comments to code.

Review: Code appears to execute as intended, nothing breaks. An editable text field appears under the temperature card in the app. Code appears to follow to established coding standards for the most part. Naming conventions, spacing looks good. However, lack of comments in the code makes it difficult to get a quick overview on what the different code sections actually "do", especially for those unfamiliar with the particulars of react, etc. Recommendation: No obstacles exist to proceed with the merge, but do recommend adding comments to code.
added api to fetch data from timeedit. Added new view for the schedule
The feedback from the first pull request has been fixed (Comments not
following standard)
When merging, make sure to 'prettify' all js files in one big go. Prettier will now change CRLF to LF.
https://prettier.io/docs/options#end-of-line:~:text=If%20you%20want%20to,to%20CRLF%20on%20checkout.
testing the shared apifetch function
- Name change: SharedFetures.js ->SharedFeatures.js
 - Change import in effected file
- Implemented unit test for failure case
 - Error 500
- Removed debug code
/TempSensorMockup
var data= new{sensor1} chaged to var data= new[]{sensor1,sensor2..}
It used to give back a object with data of a single sensor now it returns an array with data from multiple sensors
/readTempSensorMockup
the read function used to expect an single object from tempSensorMockup but as its an array now its been changed to expect an array and a foreach loop have been intruduced to read and store the data from all sensors in the array
/tempService
i have included the sensorId in the class TempratureData, even if we stored sensorId,timestamp and temperature in the db we could only use the last two before in the View's/app it doesnt do anything now but its added to be able to make out witch sensor gives the reading.
I removed the .prettierrc file content temporarily until the weekly merge.
This reverts commit 5cd8a88118.
I removed the .prettierrc file content temporarily until the weekly merge.
Reviewed-on: #160
Reviewed-on: #180
I just capitalized "UseApi" and the description to comply with the coding standard.
Reviewed-on: #163
Reviewed-on: #137
renamed hook (api call) to match coding standards
missed a file name (coding standards)
changed the hooks to use the useApi method.
added some descriptions regarding the parameters for the metobs API
we can save data from diffrent sensors and get it, but we have to be able to sort the data from diffrent sensors witch is the next problem.
Parprograming with: a22erigr
Add MapView component with floor images

- Create MapView.js
- Add floor1 and floor2 SVGs to assets
The api for both single and and entire history works when not using params to choose sensor
Latest- works with params as well to get from a specific sensor
all- doesnt work when choosing a specific sensor with params, it gets the param as unnown when we try to send it along

par programing with a22erigr
The Issue#7 and #12 is implimented in this branch, we can now create as manny mock sensors as we like, save the data to the db and querry it for either the latest temp or historic temp for each sensor seperatly.
If the historic data is going to be used it still needs to be filtered/sliced to get the intervalls and amount of data points wanted
Reviewed-on: #151
Add ImageView component with dynamic props

- Display image, title, and description
- Create ImageView.js
- Add Image1 SVG to assets
Reviewed-on: #213
Reviewed-on: #225
Reviewed-on: #216
+ Dependency for api
+ change indentation to follow standard
+ Removed out commented code
+ Added comments to explain the code
+ Incerted found no result logic
Added max width for the picture
This reverts commit f54a3d2b99.
This reverts commit 579757b585.
This reverts commit 5fa130c247, reversing
changes made to 6348c321d1.
This reverts commit ebe7becab4.
The "bug" was me centric and therefore easy to fix. Simply changing to a clean, new install browser fix it.

The bug was that the frontend didn't get data from the tempature service
+ useTemperatureTimeSeriesView and useTemperature uses the shared api
function useApi
+ All function that previously used useApi have been modified to also
send dependencies. Send null if no dependencies are needed.
Reviewed-on: #253
+./docker_postgres_init.sql:/docker-entrypoint-initdb.d/docker_postgres_init.sql:z
+ Amended :z
the database sensor is now created in init sql file
Reviewed-on: #274
Reviewed-on: #280
Reviewed-on: #239
Reviewed-on: #284
Reviewed-by: Abdalrahman Alhindi <c22abdal@noreply.localhost>
Reviewed-on: #293
This reverts commit 2b850fea62, reversing
changes made to 73f4e7583c.
c24elipe force-pushed 108-Research-test-display-text-card from c3bfa738cd to 73f4e7583c 2026-04-14 13:23:37 +00:00 Compare
c24elipe force-pushed 108-Research-test-display-text-card from c3b3bfaf2a to 73f4e7583c 2026-04-14 13:26:49 +00:00 Compare
c24elipe force-pushed 108-Research-test-display-text-card from a4fa25fbfa to 73f4e7583c 2026-04-14 13:29:47 +00:00 Compare
c24elipe commented 2026-04-14 13:31:00 +00:00
Collaborator
Copy link

The solution to the conflict is to take team_1's app.js and just commit it here. Tried some other solutions, didn't work... Just do that (after review), and the PR will be good to go

The solution to the conflict is to take team_1's app.js and just commit it here. Tried some other solutions, didn't work... Just do that (after review), and the PR will be good to go
b24johka changed target branch from team_1_week_1 to temp-week-2-merge-branch 2026-04-15 09:18:19 +00:00
b24johka commented 2026-04-15 11:45:06 +00:00
Collaborator
Copy link

manually merged into temporary branch

manually merged into temporary branch
b24johka closed this pull request 2026-04-15 11:45:06 +00:00
a22erigr deleted branch 108-Research-test-display-text-card 2026-05-04 12:14:29 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b24idalu
a24nedka
f21marfo
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!182
No description provided.