Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#786-parkingApiMockup-unit-tests-are-broken #928

Merged
a22erigr merged 5 commits from #786-parkingApiMockup-unit-tests-are-broken into team_2_week_5 2026-05-13 07:35:09 +00:00
Conversation 3 Commits 5 Files changed 1 +62 -72
a21jonfa commented 2026-05-12 14:13:31 +00:00
Collaborator
Copy link

remade the tests for the parkingApiMockup. it now tests to make sure that all mockup values are being set correctly and that the mockup changes to the spots are also correct

remade the tests for the parkingApiMockup. it now tests to make sure that all mockup values are being set correctly and that the mockup changes to the spots are also correct
Some code was nestled, seperated clock, energy and energyall.
Added comment
Reviewed-on: #775
Reviewed-by: c24danli <c24danli@noreply.localhost>
Reviewed-on: #777
Reviewed-on: #785
Reviewed-by: b24idalu <b24idalu@noreply.localhost>
Reviewed-on: #781
Based on b24krila's comments in issue #643, as well as some of my own thoughts
Reviewed-on: #783
Added a null return statement.
Reviewed-on: #796
Reviewed-by: b23albst <b23albst@noreply.localhost>
Reviewed-on: #795
Reviewed-on: #793
Removed and resized stuff to make the card fit better.
Add pointer cursor to hamburger menu on hover
Removed some margin for the card.
Reviewed-on: #817
Reviewed-on: #805
Reviewed-on: #806
Make grid cells square at all zoom levels
Script to add csproj to slnx
Sorry for activity farming
Added script for Linux/Mac same as the one for Windows
Fixed some content not being shown.
Reviewed-on: #823
Reviewed-on: #790
Reviewed-by: Vincent Lamppa Lönnbro <a24vinla@noreply.localhost>
Reviewed-on: #819
Reviewed-on: #816
Reviewed-by: b24idalu <b24idalu@noreply.localhost>
Reviewed-on: #842
Done by j21marbr
Fixed the reviewers feedback
Reviewed-on: #830
Done by @c22abdal
Reviewed-on: #832
Done by @c22abdal
Removed the hamburger menu and replaced it with two navigation buttons using Material Design icons.

Added:
- Settings button
- User button

Updated styling to support both light and dark themes using existing theme variables.
Due to some local issue, i couldn't verify that the decimals have been reduced to one. However, code wise the change has been made in TemperatureView.js
- Updated Settings.js to accept localization.
- Updated the localization files with new key-string pairs for the settings page.
- Replaced all titles and descriptors on the settings page with the new translate function.
Reviewed-on: #854
Done by  j21marbr
Replaced all Console.WriteLine calls with ILogger in layoutService. LogError for catch blocks, LogInformation for endpoint calls and database operations.
Reviewed-on: #878
Reviewed-on: #826
Replaced imported MUI icons with local SVG icons
- Removed unused dependencies from last comit
- Updated styling to follow current CSS conventions
- Finished localizing UI buttons on settings page.
- Localized the "about us" page.
- Fully localized the Support page.
Reviewed-on: #884
Reviewed-by: Abdalrahman Alhindi <c22abdal@noreply.localhost>
Reviewed-on: #875
Done by j21marbr
- Added localization to the Dashboard.
- Added localization to the Add Card Modal.
- Added localization to the Danger Modal.
- Added localization to the legal page.
Reviewed-on: #827
Made changes locales strings based on feedback.
Reviewed-on: #897
Reviewed-by: Noah Berhane <a24noabe@noreply.localhost>
Reviewed-on: #914
a21jonfa changed target branch from team_1_week_5 to team_2_week_5 2026-05-12 14:14:04 +00:00
a21jonfa commented 2026-05-12 14:14:38 +00:00
Author
Collaborator
Copy link

accidentally added the team 1 branch instead of the team 2 one, think i fixed it

accidentally added the team 1 branch instead of the team 2 one, think i fixed it
👍 1
a22erigr 2026-05-13 06:37:33 +00:00
a24vinla commented 2026-05-13 07:08:25 +00:00
Collaborator
Copy link

Review on #786

Whats done

Tested on Windows

  • Tests run!
    • All tests ran and passed

Inspected following files

  • generateMockup/parkingMockup/parkingApiMockup.Tests/SpotGeneratorTests.cs
    • Indentation/code styling
      • Styling is OK
    • Naming convention [Including filename ]
      • Follows naming convention
    • Comments
      • Test Constructor_CreatesZonesWithCorrectZoneCodes(), Constructor_MarksDisabledSpotsCorrectly() and Constructor_MarksReservedSpotsCorrectly() requires summary comments, like those that can be found in the other tests
    • General code quality
      • Good quality!
  • generateMockup/parkingMockup/parkingMockup.sln
    • Should not exist

What needs to be done

Add summary comments and remove .sln file

Conclusion

  • All tests run!
  • However, we only test hardcoded values (the reserved, disabled, zone count are all set), meaning the tests are somewhat redundant.
# Review on #786 ## Whats done ### Tested on Windows + Tests run! + All tests ran and passed ### Inspected following files + generateMockup/parkingMockup/parkingApiMockup.Tests/SpotGeneratorTests.cs + Indentation/code styling + Styling is OK + Naming convention [Including filename ] + Follows naming convention + Comments + Test Constructor_CreatesZonesWithCorrectZoneCodes(), Constructor_MarksDisabledSpotsCorrectly() and Constructor_MarksReservedSpotsCorrectly() requires summary comments, like those that can be found in the other tests + General code quality + Good quality! + generateMockup/parkingMockup/parkingMockup.sln + Should not exist ## What needs to be done Add summary comments and remove .sln file ## Conclusion + All tests run! + However, we only test hardcoded values (the reserved, disabled, zone count are all set), meaning the tests are somewhat redundant.
a24vinla approved these changes 2026-05-13 07:32:41 +00:00
a22erigr merged commit 5a2c7abe93 into team_2_week_5 2026-05-13 07:35:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24vinla
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!928
No description provided.